Clarify fetch() error handling behavior for Response #42497
Merged
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a short note explaining that fetch() only rejects on network errors and that HTTP error responses should be handled using Response.ok or Response.status.
Corrected spacing and formatting issues in the response documentation.
wbamberg
reviewed
Dec 22, 2025
Collaborator
wbamberg
left a comment
There was a problem hiding this comment.
Thanks for your PR!
It would be better to update the example to handle this error case. Note that both the basic example in the fetch() page and the first example in the Using the Fetch API do this properly.
Added error handling for fetch response in example code.
Contributor
Author
|
Thanks for the suggestion! I’ve updated the example to explicitly handle HTTP error cases using |
Contributor
|
Preview URLs (comment last updated: 2025-12-23 04:31:19) |
wbamberg
requested changes
Dec 23, 2025
Collaborator
wbamberg
left a comment
There was a problem hiding this comment.
Thank you, the code sample looks good to me. Just had a comment on the note.
Removed note about fetch promise rejection behavior.
wbamberg
added a commit
to wbamberg/content
that referenced
this pull request
Dec 24, 2025
…skeys-guide * origin/add-passkeys-guide: Clarify fetch() error handling behavior for Response (mdn#42497) Add code example to Closure glossary entry (mdn#42477) 42252 add new relative units ff release (mdn#42470) Remove duplicated word (mdn#42496) 42252 add new relative units (mdn#42469) TrustedTypes: Range.createContextualFragment() (mdn#42493) Fix CSS, HTML, and HTTP landing pages to match sidebar content and order (mdn#42460) TT: CSP trusted types/require-trusted... fixes (mdn#42461) Improve console output formatting in Recursion glossary (mdn#42478) Add Sec-CH-Width + consistency fixes (mdn#42453) webextensions/manifest.json/options_page: typo (mdn#42394) webextensions/api/tabs/onupdated: Fix section link (mdn#42393) fix: add missing closing parenthesis (mdn#42482) docs: mark srcData as required in bufferSubData (mdn#42483) docs(learn): remove invalid type attribute from video example (mdn#42479) Drop 'read-only' from role (mdn#42474) Fix: Update bufferSubData parameters to match WebGL 1 spec mdn#42315 (mdn#42411) chore: Replace links with `cssxref` macro in the learn area (mdn#42446)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a small clarification note explaining that fetch() only
rejects on network errors and that HTTP error responses should be
handled using Response.ok or Response.status.