This repository has been archived by the owner on Mar 11, 2024. It is now read-only.
Update test suite and fix nested hashes #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree this, this should be added 👍 it's better than mine at #6 |
|
Thanks @warmwaffles ! |
|
Now if we could get the repo owner to merge it. |
|
Is this ever going to get merged? I might need to drop support a ticket. |
|
@warmwaffles Thanks for reaching out, I will be taking a look at this pull request within the next day or so to see if we can get it merged in. |
|
@ryansch On this pull request would it be possible to squash your commits? |
|
Sure. How many commits would you like in the end? One? Two? |
Updating test suite to work with modern deps Marking bad tests as pending blank? is not a ruby method Replacing Addressable with Rack::Utils Fix initialization of OpenCascade Fix hashery version at 2.0.1 or higher
|
@jeremywrowe I went ahead and squashed everything down to one commit. |
|
@ryansch thanks! |
jeremywrowe
added a commit
that referenced
this pull request
Jan 17, 2013
Update test suite and fix nested hashes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally started hacking on chargify2 to fix the nested hash issue introduced by Addressable's attitude in recent releases (sporkmonger/addressable#77).
To fix this problem, I had to get the test suite running again. This pull contains the changes needed to get chargify2 testing again along with a fix for the first issue.
There were 2 tests that I marked as pending. They referred to an unknown method
a_request.