Always use multicasts for service discovery#1127
Merged
marcelveldt merged 1 commit intomainfrom Apr 10, 2025
Merged
Conversation
The unicast service discovery leads to unicast responses. However, only a single process can receive a unicast response. This is a problem since the Matter Server is most likely not the only mDNS client on a given host. By default, the service discovery starts with an unicast request first and continues with multicast requests from then onwards (the first multicast request is sent about 200ms later). So service discovery worked with the default initialization too. But with this change we get rid of the unicast request speeding up the service discovery slightly.
marcelveldt
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unicast service discovery leads to unicast responses. However, only a single process can receive a unicast response. This is a problem since the Matter Server is most likely not the only mDNS client on a given host.
By default, the service discovery starts with an unicast request first and continues with multicast requests from then onwards (the first multicast request is sent about 200ms later). So service discovery worked with the default initialization too. But with this change we get rid of the unicast request speeding up the service discovery slightly.