Open
Conversation
Before that the behavior on Windows when running rustup-init without having build tools installed was to continue. Now the user need to explicitly choose to continue installation, and thus we are making sure they are carefully reading the warning message. Closes: #2514
Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
In preparation for adding zstd support to rustup, this rework means that we treat compression formats we have available (and know) generically without breaking if unexpected formats are present, or if no format we know is present. Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
compression: Refactor handling of compression formats
Handle modifying rc files that don't have a trailing newline
…to local-toolchain
Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
If the manifest contains zst_tar and zst_hash then treat them as ZStd compressed data. Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
This is needed so that proxy commands (like `cargo` -> `rustc`) will continue to use the path toolchain.
Add the missing tools for valid_proxy_names
Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
Add sha256 file links
Add ToolchainComponentsMissing error msg
Fix broken title
show active-toolchain with rustc info
Give a better error when std is missing for a target
anyhow provides significantly better error tooling than error_chain, without the derivation support, thiserror fills that gap.
SyncError provides adaption to wrap around error_chain, both where we use it, and if any libraries rustup is using use it. Once introduced we can start incrementally migrating function and error at at time to anyhow without requiring a single big bang commit.
Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
The main UI impact is that using the anyhow formatters removes some custom code at a slight UI change - rather than repeating the err! macro output around each item in the backtrace, we get it just once (see the comment in common.rs).
anyhow instead of error_chain
Make clippy happy
There were a few error paths missed since they're only used in rare cases or unusual platforms (e.g. ones which do not support `ring`) Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
…rocess Make some pub structs/functions crate-public
Diagnosis by Daniel. Code by Robert.
Fixes #2748 by filling the streaming buffers fully
download: Fix some error paths for anyhow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )