Add support DNS RR types 64 and 65 (SVCB and HTTPS) #104
+987
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This commit adds support for HTTPS SVCB record, both encoding and decoding.
* Added Service Binding RR support (type 64) This is just using the exact same code as the HTTPS parser as they are formatted in the same manner.
Author
|
Thanks for re-running the CI/CD. I will fix these, however, what version of Node are you running against? I am on v.22.17.0. Object.entries has been around for a while now. |
- Fixed typo with Buffer.readUint8 vs readUInt8 that is incompatible with older js - Removed usage of Object.entries and replaced with for (key in obj)
This reverts commit 3b7f88d.
Author
|
Ok, Changes are up in the PR branch. Hopefully this gets us through. Thanks again. |
Author
|
I'm bumping this again so we can get the CI/CD run going |
Author
|
Any chance you can run the CI/CD again? Thank you. |
Author
|
Weekly bump |
|
👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds encoding and decoding support for SVCB and HTTPS RR types. It should address #95