copy example dependencies based on depthai's new DEPTHAI_INSTALL_PREFIX variable#9
Open
copy example dependencies based on depthai's new DEPTHAI_INSTALL_PREFIX variable#9
Conversation
…iable Updated post-build command for Windows to copy DLLs from a specified directory.
moratom
reviewed
Oct 1, 2025
Contributor
moratom
left a comment
There was a problem hiding this comment.
Since this doesn't "install" OpenCV to the build folder anymore, we should either add this back or add step by step instructions how to get this running on a fresh windows machine.
I would also change that the OpenCV installation can be done by choco in the README, similar to depthai-core.
Contributor
Author
|
I added back the original way of copying over all dependent DLLs, though I still think we should keep in the proposed way of copying over DLLs that only depthai-core depends on. This, in my view, serves as a good example for everyone who wants to use our library, irrespective of whether they want to copy over all dependencies or just those of depthai-core's. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.