Fixed error when adding shipping/billing address to order without existing address #2393
+37
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks @jamiesage123 but it seems this is a duplicate of #2375 , if you think changes you have made here should be included on that PR feel free to comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #2392.
When attempting to edit a shipping or billing address on an order that doesn't have one yet, the system throws an error trying to call methods on a null relationship, preventing the address from being added.
This pull request changes the
DisplaysOrderAddresses.phpto handle creating a new address when one doesn't exist, on top of the existing logic allowing editing, while keeping the activity log for both scenarios.