Add smooth scroll support in GthImageViewer#247
Open
darkowlzz wants to merge 1 commit intolinuxmint:masterfrom
Open
Add smooth scroll support in GthImageViewer#247darkowlzz wants to merge 1 commit intolinuxmint:masterfrom
darkowlzz wants to merge 1 commit intolinuxmint:masterfrom
Conversation
Enabling smooth scroll support in image viewer allows touch pad (on laptops) to zoom-in/zoom-out and change image without a mouse with a wheel. The zoom and image change scenarios are handled differently. Since smooth/non-discrete change in zoom level is preferable, the scroll delta is directly used to change the zoom level. But in case of image change, directly applying even a tiny scroll delta change +/- can result in quick and large jump in image change. A small threshold is introduced to reject tiny scroll delta which may result in unintended image change. This still allows large jumps in image change using scroll above the threshold.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling smooth scroll support in image viewer allows touch pad (on laptops) to zoom-in/zoom-out and change image without a mouse with a wheel.
The zoom and image change scenarios are handled differently. Since smooth/non-discrete change in zoom level is preferable, the scroll delta is directly used to change the zoom level. But in case of image change, directly applying even a tiny scroll delta change +/- can result in quick and large jump in image change. A small threshold is introduced to reject tiny scroll delta which may result in unintended image change. This still allows large jumps in image change using scroll above the threshold.
I'm not sure if the scroll delta threshold for image change is the best we can do. I'm open for any suggestions.