Enable scroll in histogram view and curve editor histogram#246
Open
darkowlzz wants to merge 1 commit intolinuxmint:masterfrom
Open
Enable scroll in histogram view and curve editor histogram#246darkowlzz wants to merge 1 commit intolinuxmint:masterfrom
darkowlzz wants to merge 1 commit intolinuxmint:masterfrom
Conversation
Both GthHistogramView and GthCurveEditor have histograms with event handler code for scroll-event but the widgets are missing the GDK_SCROLL_MASK bit for events, resulting in no scroll support. The event handlers already exist. Adding the mask bit makes the event handlers effective.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
GthHistogramViewandGthCurveEditorhave histograms with event handler code forscroll-eventsignal to switch the channels but the widgets are missing theGDK_SCROLL_MASKbit for events, resulting in no scroll support. The event handlers already exist. Adding the mask bit makes the event handlers effective.If scrolling over the histograms channels were intentionally disabled, I can update the code to remove the event handlers.
I noticed this while trying to figure out how to add smooth scroll (touch pad) support in the browser/image-viewer. Only scrolling with mouse-wheel is supported at present, which requires an external mouse on a laptop. I'll submit a separate change for that once it's ready.