image-viewer: Add equal key for image-zoom-in#245
Open
darkowlzz wants to merge 1 commit intolinuxmint:masterfrom
Open
image-viewer: Add equal key for image-zoom-in#245darkowlzz wants to merge 1 commit intolinuxmint:masterfrom
darkowlzz wants to merge 1 commit intolinuxmint:masterfrom
Conversation
In alignment with xviewer, add the equal key as a shortcut for image-zoom-in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In alignment with xviewer, add the equal key as a shortcut for image-zoom-in.
On Linux Mint 22.3 Xfce and Cinnamon, I could not use the "+" key (
GDK_KEY_plus) for zoom-in on an image in Pix. Not even in combination with Shift or Ctrl key. But zoom-out worked perfectly with "-" key.Looking at the code, I tried adding the "=" key and that made it work. I looked for the same in the xviewer repository and found out that it too uses multiple keys for supporting zoom-in, refer https://github.com/linuxmint/xviewer/blob/becb779a65e7ef18dcd2edaed8cfcd62b4497ef4/src/xviewer-scroll-view.c#L1623-L1625.
This also lead me to try using the keypad + and - keys, and they don't work. If it's acceptable, I can submit another change adding support for
GDK_KEY_KP_AddandGDK_KEY_KP_Subtractkeys for zoom-in and zoom-out respectively.