List view: show expander when a previously empty folder gets items#3743
Open
gkatev wants to merge 1 commit intolinuxmint:masterfrom
Open
List view: show expander when a previously empty folder gets items#3743gkatev wants to merge 1 commit intolinuxmint:masterfrom
gkatev wants to merge 1 commit intolinuxmint:masterfrom
Conversation
In the same way that we remove the dummy row when we know the folder doesn't have any items in it, do add one when we know that it does have items.
1ce5c90 to
6ac16bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the same way that we remove the dummy row when we know the folder doesn't have any items in it, do add one when we know that it does have items.
This addresses the OP's initial concern in #2537. There are a bunch of issues around the list view and when to show expanders, with perhaps the most problematic one being when the change occurs in an unexpanded/unwatched folder.
This PR does not attempt to fix all these issues, only the simplest of them: When an previously empty folder gets an item and nemo does know about it, e.g. because nemo itself did it, add a dummy row to trigger showing an expander. This doesn't 'watch' the folder, and clicking on the expander will still cause nemo to 'load' its items. This is the same behavior as if the folder was non-empty when we first opened the view.