Skip to content

Set mesh ghosting functor periodic boundaries - #4649

Merged
roystgnr merged 3 commits into
libMesh:develfrom
roystgnr:set_mesh_pbcs
Nov 6, 2026
Merged

roystgnr merged 3 commits into
libMesh:develfrom
roystgnr:set_mesh_pbcs

Conversation

@roystgnr

@roystgnr roystgnr commented Nov 6, 2026

Copy link
Copy Markdown
Member

Fixes #1728 for me.

This is a big improvement over the status quo. Our new DirichletConstraintValues test, instead of breaking on distributed meshes on 11 ranks (and IIRC 23 and maybe somewhere higher) now passes on at least 1 through 32 ranks (probably exhaustive, for a mesh with 32 elements). systems_of_equations_ex9 now passes on the previously failing 21 rank case (and every other count from 1 to 64). I'll start a 1-to-64 dbg sweep testing everything next.

This is also obviously a hack. It won't be sufficient in cases where we have multiple systems and there's a periodic boundary geometry that exists on later systems but not the first system; those cases will still have to fall back on our existing distributed periodic constraint calculation mechanism, "dumb luck".

But @lindsayad tells me "I’ve removed the dependence of the constraint elimination PRs on this PR so there is no rush to me to resolve this", and I've mostly been in a panic over the devel→master failures from DirichletConstraintValues that should be fixed here, so I'm no longer in a rush either. Assuming this doesn't regress anything elsewhere, it should give us time to continue the discussion in #4637 and come up with the right fix for distributed-mesh PBCs. ...or the right fixes, plural? I'm beginning to think that "tell every mesh ghosting functor about every one of multiple PBC sets" and "change the PBC constraint calculations to work without periodic point neighbors" are both things we should do... probably in that order, since the first fix will be much more straightforward than the second.

We need to set PBCs automatically, but in cases where there's already a
setting we'd probably best avoid overwriting it until we can handle
multiple sets.
We can query from the const iterators but if we want to
set_periodic_boundaries that's non-const.
This gets us periodic point neighbors, which we need to be able to
examine for our current periodic constraints algorithm to assign a
consistent constraint ordering.

@lindsayad lindsayad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an infinite improvement over the previous automatic handling of periodic bc geometric ghosting in the library

@roystgnr
roystgnr enabled auto-merge November 6, 2026 18:58
@moosebuild

Copy link
Copy Markdown

Job Coverage, step Generate coverage on 282dd99 wanted to post the following:

Coverage

8ec2e9 #4649 282dd9
Total Total +/- New
Rate 66.56% 66.58% +0.02% 100.00%
Hits 81112 81152 +40 16
Misses 40755 40731 -24 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

@roystgnr
roystgnr merged commit 6176b2a into libMesh:devel Nov 6, 2026
23 of 27 checks passed
@roystgnr
roystgnr deleted the set_mesh_pbcs branch November 6, 2026 19:55
@roystgnr

roystgnr commented Nov 6, 2026

Copy link
Copy Markdown
Member Author

Huh. Auto-merge didn't wait for the dbg distributed sweeps to finish. That was unexpected. They're 3/4 of the way done now that I check, though, and that includes passing the recipe step that's been failing for devel->master merges, so probably best that it merged ASAP.

@lindsayad

Copy link
Copy Markdown
Member

lol that's weird

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

systems_of_equations_ex9 fails on DistributedMesh on 21 processors

3 participants