Repository navigation
Fix Wsign-compare warning/error - #3349
Merged
Merged
Conversation
Member
Author
|
Added the failing CI recipes here. |
Member
|
Ugh. I don't get how it passed all the CI though, don't we have some |
Member
Author
|
We do, but I'm betting we only have them with 64-bit PETSc right now, and |
Member
Author
|
And hopefully that fixes the |
Member
|
This lets us use the solver's comm() in cases where we can't throw exceptions.
|
Job Coverage on a9a8f02 wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
Why'd we even write this maximum-compatibility macro if we weren't going to use it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3208 is failing a few of the devel->master CI checks because of this.
https://civet.inl.gov/event/94816/