Skip to content

Fix index selection in PeriodicBoundary code - #2700

Closed
roystgnr wants to merge 1 commit into
libMesh:masterfrom
roystgnr:pbc_fix
Closed

roystgnr wants to merge 1 commit into
libMesh:masterfrom
roystgnr:pbc_fix

Conversation

@roystgnr

@roystgnr roystgnr commented Sep 8, 2020

Copy link
Copy Markdown
Member

This alone wasn't sufficient to fix the problem that @arovinelli ran
into with their hand-altered neighbor_ptr topologies, but it might at
least be a corner-case fix for someone else.

This alone wasn't sufficient to fix the problem that @arovinelli ran
into with their hand-altered neighbor_ptr topologies, but it might at
least be a corner-case fix for someone else.
@roystgnr

Copy link
Copy Markdown
Member Author

I can reproduce this, and it looks like it actually interacts with a different bug, so by fixing one case I've made a more common case worse. Going to close this and get back to work on actually replacing this code with something better rather than just patching it up.

@roystgnr roystgnr closed this Sep 14, 2020
@arovinelli

Copy link
Copy Markdown

I can reproduce this, and it looks like it actually interacts with a different bug, so by fixing one case I've made a more common case worse. Going to close this and get back to work on actually replacing this code with something better rather than just patching it up.

It sounds like a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants