Repository navigation
Conversation
This alone wasn't sufficient to fix the problem that @arovinelli ran into with their hand-altered neighbor_ptr topologies, but it might at least be a corner-case fix for someone else.
Member
Author
|
I can reproduce this, and it looks like it actually interacts with a different bug, so by fixing one case I've made a more common case worse. Going to close this and get back to work on actually replacing this code with something better rather than just patching it up. |
It sounds like a good idea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This alone wasn't sufficient to fix the problem that @arovinelli ran
into with their hand-altered neighbor_ptr topologies, but it might at
least be a corner-case fix for someone else.