-
Notifications
You must be signed in to change notification settings - Fork 170
Add certificate lifetime configuration option #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add certificate lifetime configuration option #361
Conversation
aarongable
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of the three mechanisms you've proposed for making this configurable, I like this approach by far the best. Just a few small comments (nothing substantive, mostly naming nits and slight simplifications) and this'll be ready to go!
|
Hm, not sure if you'd see my latest comment above, so I'll repeat it here:
Which results in this: |
andygabby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
An alternative to #353, probably not necessary to add both 😛