Feature/2015 03 24 #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
现在 dist 目录也进 repo 了，需要 gulp release 更新 dist。 |
lib/search.js
Outdated
Contributor
There was a problem hiding this comment.
提个建议，但是不一定要改。
感觉这个 AV._request() 接口可以改为 AV._request(options)
这样每次就不用传 null，而且也不用记住参数的位置，
因为每个参数就会有个 key，所以 review 的人也能更了解每个参数的含义。
Contributor
Author
There was a problem hiding this comment.
这个要改动很多地方，这次 PR 不改了，我记录下。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AV.User.become