feat: warn that payload filtering has no effect with FDv2 - #518
Open
beekld wants to merge 4 commits into
Open
Conversation
Co-Authored-By: Bee Klimt <bklimt@launchdarkly.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
3 tasks
jsonbailey
requested changes
Sep 4, 2026
|
|
||
| self._config = config | ||
| self._data_system_config = data_system_config | ||
|
|
Contributor
There was a problem hiding this comment.
Can you rebase or merge in main to your branch. Its out of date and missing the async fdv2 file where this warning should also be added.
Contributor
There was a problem hiding this comment.
Merged main in and added the same warning (plus tests) to AsyncFDv2.__init__ in ldclient/impl/datasystem/async_fdv2.py. The AsyncConfig.payload_filter_key docs were already updated in the original commit.
…-payload-filter-warning
Co-Authored-By: Bee Klimt <bklimt@launchdarkly.com>
beekld
marked this pull request as ready for review
September 4, 2026 20:52
keelerm84
approved these changes
Sep 4, 2026
…-payload-filter-warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents and warns that
payload_filter_keyhas no effect when the FDv2 data system is used.Closes SDK-2973.
Config.payload_filter_key/AsyncConfig.payload_filter_keydocs now state payload filtering is unsupported with FDv2Requirements
Related issues
SDK-2973, part of SDK-2575. Same change as java-core#209 and go-server-sdk#440, adapted for the shared option.
Implementation details
Unlike Go and Java, Python has no FDv2-specific filter setter —
payload_filter_keyis a top-level option shared by FDv1 and FDv2 — so it cannot be deprecated at the language level without also deprecating supported FDv1 usage. Instead the docstrings call out the FDv2 limitation andFDv2.__init__warns once when the option is set.The FDv2 data sources still append
?filter=to/sdk/polland/sdk/streamrequests. That is intentional for now: on the delivery side, FDv2 (internal/fdcoreinstreamer) reads thefilterquery param only for observability (fdrequest.Info.HasPayloadFilter, surfaced as a dogfood context attribute) and never uses it to select a payload, so the parameter is inert rather than harmful. Dropping it would also break theenvironment_filter_keycontract-test scenarios that the pinned harness (v3.0.0-alpha.6) still runs, requiring suppressions until the harness pin is bumped past sdk-test-harness#431. Removing the parameter belongs with that bump in the removal phase.Testing:
make lint,make test(1420 passed).Link to Devin session: https://app.devin.ai/sessions/ed604c6db94d452ea9f2dc35d6acc398
Open in Devin Desktop: https://app.devin.ai/desktop/session/ed604c6db94d452ea9f2dc35d6acc398?variant=devin
Requested by: @beekld
Note
Overview
Clarifies that
payload_filter_keystill applies to default FDv1 streaming/polling, but does not filter FDv2 payloads.ConfigandAsyncConfigdocstrings (constructor param andpayload_filter_keyproperty) now state that filtering is unsupported with the FDv2 data system.FDv2andAsyncFDv2emit a one-time warning at construction when a filter key is set, without changing runtime behavior or deprecating the shared option for FDv1.Tests assert the warning appears when a filter key is configured and is absent when it is not, for both sync and async FDv2.
Reviewed by Cursor Bugbot for commit eaa3d72. Bugbot is set up for automated code reviews on this repo. Configure here.