Skip to content

[13.x] FIX flaky dominantColor() test - #60997

Merged
taylorotwell merged 1 commit into
laravel:13.xfrom
lucasmichot:fix-flaky-dominant-color-alpha
Aug 3, 2026
Merged

[13.x] FIX flaky dominantColor() test#60997
taylorotwell merged 1 commit into
laravel:13.xfrom
lucasmichot:fix-flaky-dominant-color-alpha

Conversation

@lucasmichot

Copy link
Copy Markdown
Contributor

Fixes flaky test seen here: https://github.com/laravel/framework/actions/runs/30786125662/job/91599886845

Resizing to 1x1 can leave alpha slightly non-opaque depending on the image library version, so dominantColor() occasionally returned an 8-char hex instead of 6. Alpha is now dropped.

@lucasmichot lucasmichot changed the title [13.x] Fix flaky dominantColor() test [13.x] FIX flaky dominantColor() test Aug 3, 2026
@jackbayliss

Copy link
Copy Markdown
Contributor

Nice, I tried setting the alpha to see if that would work, but seems like it didnt

You can revert it here if you fancy it?

$imagick->setImageAlphaChannel(\Imagick::ALPHACHANNEL_OPAQUE);

@taylorotwell
taylorotwell merged commit 5fa5027 into laravel:13.x Aug 3, 2026
55 checks passed
@lucasmichot
lucasmichot deleted the fix-flaky-dominant-color-alpha branch August 3, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants