Skip to content

[13.x] Sync property docblocks with their parent declarations - #60991

Merged
taylorotwell merged 1 commit into
laravel:13.xfrom
dfinchenko:sync-property-docblocks-with-parents
Aug 2, 2026
Merged

[13.x] Sync property docblocks with their parent declarations#60991
taylorotwell merged 1 commit into
laravel:13.xfrom
dfinchenko:sync-property-docblocks-with-parents

Conversation

@dfinchenko

@dfinchenko dfinchenko commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Nine properties are annotated more loosely than the property they override, so the child annotation throws away type information the parent already declares:

  • $aliases on six migration generator commands (cache:table, notifications:table, queue:table, queue:failed-table, queue:batches-table, session:table) is @var array, while Command::$aliases is @var string[]. Each one holds a list of command name strings.
  • $providers on ConsoleSupportServiceProvider and FoundationServiceProvider is @var string[], while AggregateServiceProvider::$providers is @var array<int, class-string<\Illuminate\Support\ServiceProvider>>. Every entry in both arrays is a ServiceProvider subclass.
  • $guarded on DatabaseNotification is @var array, while Model::$guarded is @var array<string>.

Docblocks only, no behavior change.

@taylorotwell
taylorotwell merged commit 251dc09 into laravel:13.x Aug 2, 2026
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants