[12.x] Prevent fatal errors when logging deprecations fails - #60907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #60893 to the 12.x branch. Reporting a deprecation should never be able to crash the application, but the logging attempt in HandleExceptions::handleDeprecationError() was only guarded against an Exception thrown while resolving the LogManager. Any Throwable raised while building or using the deprecations channel, such as an Error triggered when a deprecation fires while Monolog's Logger class is still mid-autoload on PHP 8.4, would fatal the process. The vulnerable code on 12.x is identical to what was fixed on 13.x, and 12.x supports the same PHP 8.4 and Monolog 3.x combinations, so the whole logging attempt is now wrapped so that any failure is ignored.