[13.x] Implement creationTimeOfOldestPendingJob on the QueueFake - #60730
Merged
taylorotwell merged 1 commit intoJul 22, 2026
Conversation
creationTimeOfOldestPendingJob on the QueueFakecreationTimeOfOldestPendingJob on the QueueFake
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
jackbayliss
force-pushed
the
13-ensure-creationTimeOfOldestPendingJob-works-on-queue-fake
branch
from
July 21, 2026 19:41
ccd1b14 to
7de5e59
Compare
jackbayliss
marked this pull request as ready for review
July 21, 2026 20:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR ensures
creationTimeOfOldestPendingJobworks on the fake, this means when we use it in commands / jobs, we can test it properly, it also means all theInspectedJobclasses have a createdAt set, which is what would happen on the real drivers, which is very useful for tests etc.The fake methods includes delayed jobs, as there's no real "delay" happening cos that's how pushed works atm too.
This now means, all the queue metrics/inspection methods are covered by the fake 🥳