Skip to content

Extend configuration by default strategy #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
scaytrase merged 1 commit into from
Sep 2, 2021
Merged

Extend configuration by default strategy #4

scaytrase merged 1 commit into from
Sep 2, 2021

Conversation

@Vabogco
Copy link

@Vabogco Vabogco commented Sep 2, 2021 •
edited
Loading

Bring possibility to configurate default strategy value.
Example:

lamoda_enum:
  enum_name_type_mapping: true
  default_strategy: lowercase
  dbal_types:
    contract_type_enum:
      class: Platform\Enum\ContractTypeEnum
      strategy: identical
    exchange_system_enum:
      class: Platform\Enum\ExchangeSystemEnum

tests are also provided.

scaytrase
scaytrase suggested changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@scaytrase scaytrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change requested. For other - 👍 looks good to me

src/DependencyInjection/Configuration.php Outdated

final class Configuration implements ConfigurationInterface
{
private array $strategies = [
Copy link
Contributor

@scaytrase scaytrase Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I this this suits better here

Suggested change
private array $strategies = [
private const STRATEGIES = [

Copy link
Author

@Vabogco Vabogco Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

scaytrase
scaytrase approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@scaytrase scaytrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@scaytrase scaytrase merged commit 7ed1840 into lamoda:master Sep 2, 2021
@scaytrase
Copy link
Contributor

scaytrase commented Sep 2, 2021

Thanks @Vabogco !

@scaytrase
Copy link
Contributor

scaytrase commented Sep 2, 2021

https://github.com/lamoda/php-enum-bundle/releases/tag/1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@scaytrase scaytrase scaytrase approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Vabogco @scaytrase