Add a flag for Non-GCP mode NEG controller.#920
Add a flag for Non-GCP mode NEG controller.#920k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
|
Hi @cxhiano. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
371e53f to
36b9548
Compare
|
/ok-to-test |
36b9548 to
a30f847
Compare
|
|
||
| // ensureNetworkEndpointGroup ensures corresponding NEG is configured correctly in the specified zone. | ||
| func ensureNetworkEndpointGroup(svcNamespace, svcName, negName, zone, negServicePortName string, cloud negtypes.NetworkEndpointGroupCloud, serviceLister cache.Indexer, recorder record.EventRecorder) error { | ||
| func ensureNetworkEndpointGroup(svcNamespace, svcName, negName, zone, negServicePortName string, networkEndpointType negtypes.NetworkEndpointType, cloud negtypes.NetworkEndpointGroupCloud, serviceLister cache.Indexer, recorder record.EventRecorder) error { |
There was a problem hiding this comment.
Consider 2 things:
-
refactor the code to structure like this:
A. construct expected NEG resource
B. Check if the existing NEG is the same as expected
C. Delete/Create/No-Op -
Or add a TODO on top and leave it later.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cxhiano, freehan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
With '--enable-non-gcp-mode', NEG controller will create NEGs of type NON_GCP_PRIVATE_IP_PORT instead of GCE_VM_IP_PORT.