Skip to content

Test for making dependancy adal optional #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
roycaihw wants to merge 1 commit into from
Closed

Test for making dependancy adal optional #750

roycaihw wants to merge 1 commit into from

Conversation

@roycaihw
Copy link
Member

@roycaihw roycaihw commented Feb 7, 2019

triggering test for #668

@micw523
Copy link
Contributor

micw523 commented Feb 7, 2019

CI looks good on #668 from what I can see.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 7, 2019
@roycaihw
Copy link
Member Author

roycaihw commented Feb 7, 2019

/close

travis-ci and bot were not responding for a while

@roycaihw roycaihw closed this Feb 7, 2019
@roycaihw roycaihw deleted the adal branch February 7, 2019 22:26
@roycaihw roycaihw restored the adal branch February 7, 2019 22:46
@roycaihw
Copy link
Member Author

roycaihw commented Feb 7, 2019

/reopen

I feel either the bot or travis-ci itself is tagging wrong PR in travis-ci when the commits are the same. reopen to verify

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 7, 2019

@roycaihw: Failed to re-open PR: state cannot be changed. These commits are already merged.

Details

In response to this:

/reopen

I feel either the bot or travis-ci itself is tagging wrong PR in travis-ci when the commits are the same. reopen to verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@roycaihw
Copy link
Member Author

roycaihw commented Feb 7, 2019

These commits are already merged

the bot/github got confused when two PRs share the exact same commits. not sure if it's a nature of github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@roycaihw @micw523 @k8s-ci-robot @iamneha