Skip to content

Use Child Logger In Leader Election #2484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sesmi123 wants to merge 12 commits into from
Closed

Use Child Logger In Leader Election #2484

sesmi123 wants to merge 12 commits into from
+17 −16

Conversation

@sesmi123
Copy link
Contributor

@sesmi123 sesmi123 commented Dec 14, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Uses a child logger in leader election module instead of logging to the root logger.

Which issue(s) this PR fixes:

Fixes

Special notes for your reviewer:

It is my first PR. Let me know if I made some mistake. Hopefully, I can make more contributions in the future :)

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

No functional changes. Behaviourally, users can now set log level like `logging.getLogger("leaderelection").setLevel(logging.INFO)`

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 14, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 14, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 14, 2025

Welcome @sesmi123!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sesmi123
Once this PR has been reviewed and has the lgtm label, please assign roycaihw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 14, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 14, 2025
@sesmi123 sesmi123 marked this pull request as ready for review December 14, 2025 07:26
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 14, 2025
sesmi123 and others added 8 commits December 14, 2025 02:29
@sesmi123
make single commit - use named logger in leader election
aa1676b
@sesmi123
Merge branch 'master' of https://github.com/sesmi123/kubernetes-clien…
0799689 
…t-python
@mazanax @sesmi123
fix: Try to recreate cached file if tmp file is not exist
6816d43
@NicoPolazzi @sesmi123
Add test case for cached file recreation
0b22f78
@dependabot @sesmi123
Bump actions/checkout from 5 to 6
39a87ce 
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v5...v6)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@Naman-cell @sesmi123
Fix: Improve RFC3339 date parsing validation (Issue #2418)
5e768f4 
- Replace search() with fullmatch() for strict RFC3339 format validation
- Provide clear, actionable error messages with expected format
- Add input whitespace stripping before validation
- Improve exception handling with specific ValueError messages
- Add comprehensive test cases for invalid formats
- Addresses reviewer feedback from PR #2420

Test: Existing tests pass + new test cases added
@sesmi123
make single commit - use named logger in leader election
f0d971a 
remove log level
@sesmi123
Merge branch 'master' of https://github.com/sesmi123/kubernetes-clien…
0ec36ea 
…t-python
@sesmi123 sesmi123 closed this Dec 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabianvf fabianvf Awaiting requested review from fabianvf

@yliaog yliaog Awaiting requested review from yliaog

@roycaihw roycaihw Awaiting requested review from roycaihw

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sesmi123 @k8s-ci-robot @mazanax @NicoPolazzi @Naman-cell