Skip to content

docs(install): create the kserve namespace before applying kserve.yaml - #766

Merged
spolti merged 2 commits into
kserve:mainfrom
sunilmehta-si:docs-standard-install-namespace
Nov 17, 2026
Merged

spolti merged 2 commits into
kserve:mainfrom
sunilmehta-si:docs-standard-install-namespace

Conversation

@sunilmehta-si

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

The "with YAML" install tabs on the Standard-mode page apply kserve.yaml straight away, but that manifest places its objects in the kserve namespace without creating it (v0.20.0 and v0.21.0 both: 0 Namespace objects, 54 objects in namespace: kserve). On a fresh cluster the apply fails with namespaces "kserve" not found and the install stops at step 1. The Helm tabs are not affected, since Helm creates the namespace.

This adds kubectl create namespace kserve to step 1 of both YAML tabs (Gateway API and Ingress), with one sentence saying why.

Found while following this page for a kind cluster in CI. Relates to #383 (the raw deployment install guide being inaccurate).

Which issue(s) this PR fixes:

Relates to #383

Feature/Issue validation/testing:

  • Reproduced on kind v0.33.0 / Kubernetes v1.37.0: kubectl apply --server-side -f kserve.yaml on a fresh cluster fails until the namespace exists; with kubectl create namespace kserve first, the install completes (our CI does this on every push).
  • Checked the release manifests: curl -sL https://github.com/kserve/kserve/releases/download/v0.21.0/kserve.yaml | grep -c '^kind: Namespace' prints 0.

Special notes for your reviewer:

Docs only. The two tabs have identical step 1 text, so the same change is made in both.

The YAML install tabs apply kserve.yaml straight away, but the manifest
puts its resources in the kserve namespace without creating it, so on a
fresh cluster the first step fails with 'namespaces "kserve" not found'.
Add the create step to both YAML tabs. The Helm tabs are unaffected.

Relates to kserve#383

Signed-off-by: Sunil Mehta <sunilmehta695@gmail.com>
@netlify

netlify Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for elastic-nobel-0aef7a ready!

Name Link
🔨 Latest commit 91bc099
🔍 Latest deploy log https://app.netlify.com/projects/elastic-nobel-0aef7a/deploys/6adc774f0fca4fde9c319fdb
😎 Deploy Preview https://deploy-preview-766--elastic-nobel-0aef7a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@greptile-apps

greptile-apps Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; namespace creation now precedes the resources that need it.

Summary

Moves creation of the kserve namespace into a shared step before the network controller.

  • The install guide creates kserve before setting up the network.

Reviews (2) · Last reviewed commit: "docs(install): create the kserve namespa..." · Reviewed by Greptile

… own step

Review feedback: the Gateway API path creates a Gateway in the kserve
namespace in the network-controller step, before KServe is installed, so
creating the namespace inside the install step came too late. Make it
step 2 of the installation, ahead of the network controller, and restore
the install tabs to applying the manifests.

Signed-off-by: Sunil Mehta <sunilmehta695@gmail.com>
@spolti

spolti commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Hi, did you follow the installation methods in the docs?
We provide some installation scripts instead using the release artifacts directly. Can you please take a look?
https://kserve.github.io/website/docs/install/kserve-install

@sunilmehta-si

Copy link
Copy Markdown
Contributor Author

Yes. The scripts in kserve-install.md create the namespace already. This PR is for the other path on kubernetes-deployment.md, applying the release YAMLs directly, where the kserve namespace has to exist first. If you'd rather that page point to the install scripts instead, I'm happy to change it.

@spolti

spolti commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

THanks @sunilmehta-si

@spolti
spolti merged commit 578fa48 into kserve:main Nov 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants