Repository navigation
docs(install): create the kserve namespace before applying kserve.yaml - #766
Conversation
The YAML install tabs apply kserve.yaml straight away, but the manifest puts its resources in the kserve namespace without creating it, so on a fresh cluster the first step fails with 'namespaces "kserve" not found'. Add the create step to both YAML tabs. The Helm tabs are unaffected. Relates to kserve#383 Signed-off-by: Sunil Mehta <sunilmehta695@gmail.com>
✅ Deploy Preview for elastic-nobel-0aef7a ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
[Low impact] The PR appears safe to merge; namespace creation now precedes the resources that need it. SummaryMoves creation of the
Reviews (2) · Last reviewed commit: "docs(install): create the kserve namespa..." · Reviewed by Greptile |
… own step Review feedback: the Gateway API path creates a Gateway in the kserve namespace in the network-controller step, before KServe is installed, so creating the namespace inside the install step came too late. Make it step 2 of the installation, ahead of the network controller, and restore the install tabs to applying the manifests. Signed-off-by: Sunil Mehta <sunilmehta695@gmail.com>
|
Hi, did you follow the installation methods in the docs? |
|
Yes. The scripts in kserve-install.md create the namespace already. This PR is for the other path on kubernetes-deployment.md, applying the release YAMLs directly, where the |
|
THanks @sunilmehta-si |
What this PR does / why we need it:
The "with YAML" install tabs on the Standard-mode page apply
kserve.yamlstraight away, but that manifest places its objects in thekservenamespace without creating it (v0.20.0 and v0.21.0 both: 0Namespaceobjects, 54 objects innamespace: kserve). On a fresh cluster the apply fails withnamespaces "kserve" not foundand the install stops at step 1. The Helm tabs are not affected, since Helm creates the namespace.This adds
kubectl create namespace kserveto step 1 of both YAML tabs (Gateway API and Ingress), with one sentence saying why.Found while following this page for a kind cluster in CI. Relates to #383 (the raw deployment install guide being inaccurate).
Which issue(s) this PR fixes:
Relates to #383
Feature/Issue validation/testing:
kubectl apply --server-side -f kserve.yamlon a fresh cluster fails until the namespace exists; withkubectl create namespace kservefirst, the install completes (our CI does this on every push).curl -sL https://github.com/kserve/kserve/releases/download/v0.21.0/kserve.yaml | grep -c '^kind: Namespace'prints 0.Special notes for your reviewer:
Docs only. The two tabs have identical step 1 text, so the same change is made in both.