This repository was archived by the owner on Jan 20, 2022. It is now read-only.
Add etcd-manager metrics, add openstack API metrics #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@justinsb could you please check this |
mitch000001
suggested changes
Feb 8, 2021
mitch000001
reviewed
Feb 8, 2021
justinsb
reviewed
Feb 26, 2021
| flag.StringVar(&o.Address, "address", o.Address, "local address to use") | ||
| flag.StringVar(&o.PeerUrls, "peer-urls", o.PeerUrls, "peer-urls to use") | ||
| flag.IntVar(&o.GrpcPort, "grpc-port", o.GrpcPort, "grpc-port to use") | ||
| flag.IntVar(&o.EtcdManagerMetricsPort, "etcd-manager-metrics-port", o.EtcdManagerMetricsPort, "etcd-manager prometheus metrics port") |
Contributor
There was a problem hiding this comment.
We could consider making this etcd-manager-listen-metrics-urls , for parity with listen-metrics-urls and to support specifying the host (and maybe the scheme). But maybe YAGNI, and it's easy enough to introduce later if we do...
| APIRequestMetrics = &OpenstackMetrics{ | ||
| Duration: prometheus.NewHistogramVec( | ||
| prometheus.HistogramOpts{ | ||
| Name: "openstack_api_request_duration_seconds", |
Contributor
There was a problem hiding this comment.
TBH I don't know the naming rules here; I'm going to assume you do, but I'm assuming this isn't part of our backwards compatibility contract. Not that we'll change them without good reason :-)
Contributor
|
Thanks @zetaab /approve |
justinsb
added a commit
to justinsb/kops
that referenced
this pull request
Mar 1, 2021
Changes: * Add user agent to etcd-manager requests [kubernetes#395](kopeio/etcd-manager#395) * Add etcd-manager metrics, add openstack API metrics [kubernetes#396](kopeio/etcd-manager#396) * Make discovery poll interval configurable [kubernetes#397](kopeio/etcd-manager#397) * Add log levels to prevent too verbose logging [kubernetes#394](kopeio/etcd-manager#394)
justinsb
added a commit
to justinsb/kops
that referenced
this pull request
Mar 1, 2021
Changes: * Add user agent to etcd-manager requests [kubernetes#395](kopeio/etcd-manager#395) * Add etcd-manager metrics, add openstack API metrics [kubernetes#396](kopeio/etcd-manager#396) * Make discovery poll interval configurable [kubernetes#397](kopeio/etcd-manager#397) * Add log levels to prevent too verbose logging [kubernetes#394](kopeio/etcd-manager#394)
hakman
pushed a commit
to hakman/kops
that referenced
this pull request
Mar 1, 2021
Changes: * Add user agent to etcd-manager requests [kubernetes#395](kopeio/etcd-manager#395) * Add etcd-manager metrics, add openstack API metrics [kubernetes#396](kopeio/etcd-manager#396) * Make discovery poll interval configurable [kubernetes#397](kopeio/etcd-manager#397) * Add log levels to prevent too verbose logging [kubernetes#394](kopeio/etcd-manager#394)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.