This repository was archived by the owner on Jan 20, 2022. It is now read-only.
Add log levels to prevent too verbose logging #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds klog.V(3).Infof instead of plain klog.Infof for frequently occuring informational events.
Contributor
|
@justinsb could you please check this |
justinsb
reviewed
Feb 26, 2021
| } | ||
|
|
||
| klog.Infof("I am leader with token %q", m.leadership.token) | ||
| klog.V(3).Infof("I am leader with token %q", m.leadership.token) |
Contributor
There was a problem hiding this comment.
Do we have any indication that we are the leader after this change?
Contributor
|
This looks good; we might want a little more logging so we know who the leader is, but I agree the current logging is probably excessive. It's a little difficult because it's hard to change without restarting the pods, but we can certainly try this direction and then add back some reasonable logging. I re-triggered the tests, it looks like it was just a networking flake. |
Contributor
|
/approve |
justinsb
added a commit
to justinsb/kops
that referenced
this pull request
Mar 1, 2021
Changes: * Add user agent to etcd-manager requests [kubernetes#395](kopeio/etcd-manager#395) * Add etcd-manager metrics, add openstack API metrics [kubernetes#396](kopeio/etcd-manager#396) * Make discovery poll interval configurable [kubernetes#397](kopeio/etcd-manager#397) * Add log levels to prevent too verbose logging [kubernetes#394](kopeio/etcd-manager#394)
justinsb
added a commit
to justinsb/kops
that referenced
this pull request
Mar 1, 2021
Changes: * Add user agent to etcd-manager requests [kubernetes#395](kopeio/etcd-manager#395) * Add etcd-manager metrics, add openstack API metrics [kubernetes#396](kopeio/etcd-manager#396) * Make discovery poll interval configurable [kubernetes#397](kopeio/etcd-manager#397) * Add log levels to prevent too verbose logging [kubernetes#394](kopeio/etcd-manager#394)
hakman
pushed a commit
to hakman/kops
that referenced
this pull request
Mar 1, 2021
Changes: * Add user agent to etcd-manager requests [kubernetes#395](kopeio/etcd-manager#395) * Add etcd-manager metrics, add openstack API metrics [kubernetes#396](kopeio/etcd-manager#396) * Make discovery poll interval configurable [kubernetes#397](kopeio/etcd-manager#397) * Add log levels to prevent too verbose logging [kubernetes#394](kopeio/etcd-manager#394)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would change Etcd-manager to use klog.V(3).Infof instead of plain klog.Infof for frequently occuring informational events.
We have been looking into logs generated by etcd-manager. Running an idle cluster with three master nodes, i.e. two etcd-manager clusters and six members with -v=1 results in about 300 000 log events in 24h, without significant deviations after running for few days.
After these changes, the number of log events is somewhere around 2000 events per day, which mostly include information about backup and compaction events.