This repository was archived by the owner on Jan 20, 2022. It is now read-only.
Simplify uploading backups #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinsb
reviewed
May 27, 2020
| if err := vfs.CopyFile(srcPath, destPath, nil); err != nil { | ||
| return "", fmt.Errorf("error copying %q to %q: %v", srcPath, destPath, err) | ||
| err = destPath.WriteFile(f, nil) | ||
| if err != nil { |
Contributor
There was a problem hiding this comment.
(Total nit): you can combine this into if err := destPath.WriteFile(...); err != nil {
justinsb
approved these changes
May 27, 2020
Contributor
justinsb
left a comment
There was a problem hiding this comment.
Thanks - well spotted and a nice fix.
/approve
/lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the dependency on
vfs.CopyFile(), which internally copies to a second temporary file.