Conversation
zapu
approved these changes
Oct 21, 2019
Contributor
zapu
left a comment
There was a problem hiding this comment.
checked sig id with team chain, LGTM
cjb
pushed a commit
that referenced
this pull request
Oct 25, 2019
* teams: fix for a broken team * fix comment
MarcoPolo
added a commit
that referenced
this pull request
Oct 25, 2019
commit d965280 Merge: e5d210c 3c75089 Author: chrisnojima <cnojima@keyba.se> Date: Fri Oct 25 11:21:11 2019 -0400 Merge remote-tracking branch 'origin/master' into nojima/HOTPOT-faster-msgpack commit 3c75089 Author: chrisnojima <cnojima@keyba.se> Date: Fri Oct 25 11:09:46 2019 -0400 fix phone (#20604) commit 7b24b01 Author: Mike Maxim <mike@keyba.se> Date: Fri Oct 25 10:59:43 2019 -0400 if we have meta, then use its snippet (#20600) commit b27ce43 Author: Danny Ayoub <danny.a95@gmail.com> Date: Fri Oct 25 10:48:16 2019 -0400 Fix tapping username to select @-mention result (#20601) commit 80804d6 Author: Mike Maxim <mike@keyba.se> Date: Fri Oct 25 10:13:12 2019 -0400 sort leftover nonspeaking parts properly (#20596) commit 0554186 Author: Jacob Young <jacob@jry.io> Date: Fri Oct 25 09:52:57 2019 -0400 Speed Up SearchFilter Focus (#20586) * Wip * Snapshots commit 8a7674a Author: Jacob Young <jacob@jry.io> Date: Fri Oct 25 09:44:39 2019 -0400 Increase minimum electron window width to 740 (#20587) commit 1c6d402 Author: cori hudson <54032873+hyperobject@users.noreply.github.com> Date: Fri Oct 25 09:30:17 2019 -0400 HOTPOT-1003: location sharing ui changes (#20574) * fix spacing and some copy * clean up location command markdown and copy * wip * use banner and bannerparagraph (wip) * add white color for banner common adapter * snaps * fix ci * fix ci 2 commit fce3981 Author: chrisnojima <cnojima@keyba.se> Date: Thu Oct 24 18:08:20 2019 -0400 Team building animations (#20509) commit 14b7468 Author: Cécile Boucheron <cecileboucheron@users.noreply.github.com> Date: Thu Oct 24 15:05:54 2019 -0700 Tweaks on relogin screen (#20563) * WIP * flex 1 * measure height and use it for content height in scrollview * new input, left-align everything * tweaks * storybook * Lint * Don't use FormWithCheckbox until we switch over to LabeledInput. * danny's feedback * no background commit 27138d5 Author: Jacob Young <jacob@jry.io> Date: Thu Oct 24 16:54:31 2019 -0400 PICNIC-584 - Consolidate User Results (#20581) * Refactor user result and people result * Add peoplpe result stories commit 08eec9b Author: Chris Ball <chris@printf.net> Date: Thu Oct 24 13:41:03 2019 -0700 Fix sending path payments to federated addresses (#20567) commit c44ed29 Author: chrisnojima <cnojima@keyba.se> Date: Thu Oct 24 16:37:17 2019 -0400 enable echo command (#20584) commit ce16709 Author: chrisnojima <cnojima@keyba.se> Date: Thu Oct 24 16:36:11 2019 -0400 fix reset username (#20583) commit 748b0da Author: Maxwell Krohn <themax@gmail.com> Date: Thu Oct 24 16:33:29 2019 -0400 libkb: loader picks fresher of stubbed/unstubbed UPAK (#20577) * libkb: loader picks fresher of stubbed/unstubbed UPAK - if called from unstubbed mode. previously, we weren't considering CachedAt for deciding between the two * in the likely case I'm wrong, add more debugging commit a8d975a Author: Mike Maxim <mike@keyba.se> Date: Thu Oct 24 16:31:11 2019 -0400 better logging in chat (#20582) * better logging in chat * better commit 33ebfb2 Author: Jakob Weisblat <jakob@keyba.se> Date: Thu Oct 24 16:27:42 2019 -0400 User switcher UI tweaks (#20568) * user switcher: UI tweaks * Update index.tsx * Update index.tsx commit 7231504 Author: Patrick Crosby <patrick@keyba.se> Date: Thu Oct 24 15:01:18 2019 -0500 Use allDetailsPlusPayments in RefreshAll (#20576) * Beginnings of using AllDetailsPlusPayments (test needs mocking in AllDetailsPlusPayments) * WIP trying to get tests to pass * Debug * Tests pass * Cleanup commit 9d95551 Author: Maxwell Krohn <themax@gmail.com> Date: Thu Oct 24 14:50:02 2019 -0400 test echo RPC (#20575) commit 09e9c29 Author: Mike Maxim <mike@keyba.se> Date: Thu Oct 24 14:17:57 2019 -0400 audio visualization (#20572) * vis * test commit e7bedac Author: chrisnojima <cnojima@keyba.se> Date: Thu Oct 24 13:33:33 2019 -0400 Bring back chat immer (#20521) commit ef7876e Author: Jeremy Stribling <strib@alum.mit.edu> Date: Tue Oct 22 16:35:47 2019 -0700 reporter_kbpki: don't send notifications after shutdown There could be a race where the mdserver sends a disconnected message after all of the reporter's channels are closed. Issue: HOTPOT-1083 commit fd88baf Author: Jeremy Stribling <strib@alum.mit.edu> Date: Tue Oct 22 15:28:50 2019 -0700 key_manager_test: sync device 3 after rekey during test A CI failure (that I couldn't repro locally) showed that a device that should have been able to read a TLF after a rekey, wasn't able to. From the log I think it was still trying to read an old version, so I'm fixing it by syncing before trying to read it from that device. Issue: HOTPOT-1059 commit d133baa Author: Adam Spooner <adamjspooner@gmail.com> Date: Thu Oct 24 11:59:18 2019 -0400 Update feedback styles. (#20571) * Update feedback view. * Use NewInput. * Prettier commit 7bbed3d Author: Joshua Blum <joshblum@keyba.se> Date: Thu Oct 24 09:53:58 2019 -0400 filter non-retriable outbox errors from thread (#20564) * filter non-retriable outbox errors from thread * fix test commit 6eda5d5 Author: chrisnojima <cnojima@keyba.se> Date: Thu Oct 24 09:36:03 2019 -0400 memory fixes (#20494) commit ef98657 Author: Taru Karttunen <taruti@taruti.net> Date: Thu Oct 24 07:55:56 2019 +0000 Linux start on login GUI item (#19991) * Linux start on login GUI item commit e5d210c Author: chrisnojima <cnojima@keyba.se> Date: Wed Oct 23 22:13:49 2019 -0400 WIP commit b307361 Author: chrisnojima <cnojima@keyba.se> Date: Wed Oct 23 22:06:29 2019 -0400 WIP commit 6ca1f92 Author: Danny Ayoub <danny.a95@gmail.com> Date: Wed Oct 23 17:55:43 2019 -0400 remove resetPipeline feature flag (#20555) * remove resetPipeline ff * mock * add userBlocking feature flag (#20556) * remove unused launch webpage actions commit 72d01a5 Author: chrisnojima <cnojima@keyba.se> Date: Wed Oct 23 16:56:20 2019 -0400 WIP commit 9193f4f Author: chrisnojima <cnojima@keyba.se> Date: Wed Oct 23 16:54:04 2019 -0400 WIP commit c1a7b11 Author: Joshua Blum <joshblum@keyba.se> Date: Wed Oct 23 16:49:39 2019 -0400 retry racy ephemeral errors (#20557) commit f4afcd7 Author: chrisnojima <cnojima@keyba.se> Date: Wed Oct 23 16:38:23 2019 -0400 WIP commit d308e2c Author: Patrick Crosby <patrick@keyba.se> Date: Wed Oct 23 15:20:09 2019 -0500 Add DepositReqAuth, WithdrawReqAuth to asset (#20554) * Add DepositReqAuth, WithdrawReqAuth to asset * Fix test commit dd48263 Author: Jacob Young <jacob@jry.io> Date: Wed Oct 23 15:58:48 2019 -0400 PICNIC-448: What's New Thingy (#20403) * Whats New * Snapshots * Padding update * Visual feedback * Fix tests * Review feedback * Partial review feedback * Make sure navigation will also close the popup * Add new images, fix styles, and new feature row * Fix inline icon size on mobile * Update copy, images, and font weight * Fix dark mode webpack path * Remove feature flag commit e1e0647 Author: Joshua Blum <joshblum@keyba.se> Date: Wed Oct 23 15:57:50 2019 -0400 fix nil conv crasher (#20558) commit 4d1d5b0 Author: cori hudson <54032873+hyperobject@users.noreply.github.com> Date: Wed Oct 23 15:52:45 2019 -0400 HOTPOT-1090: fix suggestor parsing (#20534) * wip * less magic values in getWordAtCursor * more comments, remove console.warn * Update shared/chat/conversation/input-area/suggestors/index.tsx Co-Authored-By: Danny Ayoub <danny.a95@gmail.com> commit 9cbab5b Author: Adam Spooner <adamjspooner@gmail.com> Date: Wed Oct 23 15:49:34 2019 -0400 Fix account deletion. (#20548) commit 25da9d8 Author: Jacob Young <jacob@jry.io> Date: Wed Oct 23 15:41:30 2019 -0400 Allow ellipsis (#20559) commit 5deb048 Author: Maxwell Krohn <themax@gmail.com> Date: Wed Oct 23 14:51:49 2019 -0400 engine: fix linting error intro'ed into PGP push (#20553) * engine: fix linting error intro'ed into PGP push * cleaner implementation * better error message * comments commit da5ce67 Author: Jacob Young <jacob@jry.io> Date: Wed Oct 23 13:45:13 2019 -0400 PICNIC-548: Service Row Pretty Name and Layout (#20475) * Hide prettyName when it matches keybase username * Fix icon styling and dont scroll on destop commit 90686b1 Author: Joshua Blum <joshblum@keyba.se> Date: Wed Oct 23 13:31:47 2019 -0400 process teamMemberRoleUpdates (#20435) * process teamMemberRoleUpdates * plumb to frontend * more plumb * interface * fix tests * fix test * move to team actions commit cc9d5b4 Author: Alex Gessner <alex.gessner@gmail.com> Date: Wed Oct 23 13:28:49 2019 -0400 manual control of revision (#20460) * add manual control of revision to team storage * team storage error if user on cli specifies revision 0 * add a test to lock in safe race behavior of team storage * consolidate revision errors from server and cache * a bunch of changes to errors so they bubble up to the CLI more usefully * cleanup commit 9068f4c Author: Danny Ayoub <danny.a95@gmail.com> Date: Wed Oct 23 13:25:38 2019 -0400 store result of team getDetails in teamDetails obj as well (#20524) * store result of team getDetails in teamDetails obj as well * review feedback commit 7082e9b Author: Jakob Weisblat <jakob@keyba.se> Date: Wed Oct 23 12:49:22 2019 -0400 fix kbfs path regex in client (#20442) * fix kbfs path regex in client * match the server regex * comments commit b58a89a Author: Cécile Boucheron <cecileboucheron@users.noreply.github.com> Date: Wed Oct 23 09:30:57 2019 -0700 Add "View/Edit profile" to user menu (#20541) * added button * xsmall commit fdfc270 Author: cori hudson <54032873+hyperobject@users.noreply.github.com> Date: Wed Oct 23 11:43:25 2019 -0400 change margin of "create an account" (#20517) makes "problems logging in?" visible on iphone se commit 61168f1 Author: Adam Spooner <adamjspooner@gmail.com> Date: Wed Oct 23 11:40:27 2019 -0400 Align switch with label when there's a label subtitle. (#20513) commit fbbac5d Author: Joshua Blum <joshblum@keyba.se> Date: Wed Oct 23 11:04:46 2019 -0400 update protocol lockfile (#20535) * fail CI if protocol lock not updated * update yarn lockfile commit 026a473 Author: Adam Spooner <adamjspooner@gmail.com> Date: Wed Oct 23 10:50:18 2019 -0400 Fix orange line on mobile. (#20550) * Fix right side. * Fix orange line when there's no username. commit de4d56a Author: Miles Steele <miles@milessteele.com> Date: Wed Oct 23 10:35:31 2019 -0400 Journey card changes (#20463) * type comments * comment * Add a placeholder for rendering journey cards * journeycard * jenkins * lint * log * disable lint singleCaseSwitch * Revert "disable lint singleCaseSwitch" This reverts commit 83fe6df. commit 3e3ef91 Author: Adam Spooner <adamjspooner@gmail.com> Date: Wed Oct 23 10:09:52 2019 -0400 De-emphasize channel hash. (#20549) commit 7f3726a Author: Adam Spooner <adamjspooner@gmail.com> Date: Wed Oct 23 09:08:12 2019 -0400 Add mic, play, stop icons. (#20547) * Add mic, play, stop icons. * Actually add them. commit 538a6c3 Author: heronhaye <surya@keyba.se> Date: Wed Oct 23 09:03:09 2019 -0400 linux secsrv ccrasher (#20536) commit a3c652d Author: Jakob Weisblat <jakob@keyba.se> Date: Tue Oct 22 16:52:52 2019 -0400 add space between system leave and join messages (#20520) commit 00aa75f Author: Michał Zochniak <michal@zapu.net> Date: Tue Oct 22 22:15:54 2019 +0200 Show service summaries in recommendations in team-building (#20236) Move ServiceMapper to G so it's available in InterestingPeople RPC handler. Because we want this RPC not to make any extra network calls, we use ServiceMapper with "no network budget", so it will only use what's in cache. However this is a problem, because unless you've had a user in contacts, you won't have their service summary in cache. This is solved by caching service summaries coming in libkb/loaduser.go (in idTable.remoteProofLinks). Because InterestingPeople returns users you either chatted with or follow, you usually had to interact with them beforehand, and therefore load them. commit 40c2b9d Author: Jeremy Stribling <strib@alum.mit.edu> Date: Tue Oct 22 11:05:21 2019 -0700 folder_branch_ops: fix archiving race when forcing conflicts A test failure showed the following situation (which I couldn't repro locally): * The force-conflict code makes and flushes its "merged" op (a `gcOp`). * It then makes its first conflict op, and puts that into the journal. This is initially marked as "unmerged", since the conflict hasn't yet been detected by FBO or the journal. * This new MD replaces the original "merged" MD in the cache. * The background process that was kicked off by the first MD flush now starts, grabs the _new_ MD from the cache, and tries to archive the pointers from it. However, these pointers are still live on the merged branch, so this causes issues. Note that this is only a problem for the force-conflicts flow, it shouldn't affect normal user workflows. The fix is just to wait for the FBO flush handler to complete its work to set up the archiving on the first MD, before writing out the conflict MDs Issue: HOTPOT-1058 commit 7fa8241 Author: Joshua Blum <joshblum@keyba.se> Date: Tue Oct 22 15:55:40 2019 -0400 short circuit inbox updates when empty (#20530) commit 3ff0629 Author: Jeremy Stribling <strib@alum.mit.edu> Date: Fri Oct 18 14:48:35 2019 -0700 keybase_service_base: cache negative writership for a short time We use cached team info when possible, unless we're checking for membership of a user that's not present in the cached info. In that case, we force a reload, just in case there's a race with the membership-changed notification from the service. Usually this is fine because it's rare to do a negative lookup multiple times in a row -- after the first error, the client will stop. However, in the case of stat-ing all the files in a public directory, we call this function over and over again to figure out if the current user is a writer (to set the writer bit in each entry's permissions), and since it's a public folder the user is not (usually) a writer, so it was forcing the service to reload the team every time, slowing things down considerably. Instead, cache the fact that a user is not a writer for a short time (5s). This is safe with respect to the FUSE calls that return permissions on a file (which tells the kernel to cache that info for one minute anyway). However it potentially sets up a race with any situations where multiple notifications race with each other when the team membership changes and we need to figure out whether the current user is now a writer. I can't think of any such situations right now, but we should keep an eye on it. Issue: HOTPOT-1009 commit 1c0d732 Author: Joshua Blum <joshblum@keyba.se> Date: Tue Oct 22 14:45:55 2019 -0400 fix snippet for clearing headline (#20519) commit 7c09e0b Author: Jakob Weisblat <jakob@keyba.se> Date: Tue Oct 22 14:25:46 2019 -0400 login: actually log out while trying to switch users (#20504) * login: actually log out while trying to switch users * improve mobile switching UX, clean up user dropdown (#20507) commit 9d2432f Author: heronhaye <surya@keyba.se> Date: Tue Oct 22 13:59:56 2019 -0400 fix debian control file for apt 1.9 commit 30ee663 Author: Song Gao <song@gao.io> Date: Tue Oct 22 10:09:30 2019 -0700 non-recursive listing for popups; disable "ignore" during stat/folderList (#20474) * non-recursive listing for popups; disable "ignore" during stat/folderList * Update shared/fs/common/hooks.tsx Co-Authored-By: Jakob Weisblat <jakob@keyba.se> * Update shared/fs/browser/rows/rows.tsx Co-Authored-By: Jakob Weisblat <jakob@keyba.se> * review feedback from jakob * remove unneeded import commit aa1aafc Author: Song Gao <song@gao.io> Date: Tue Oct 22 09:29:01 2019 -0700 add SimpleFSGetFolder for out-of-favs or non-preferred TLF paths (#20486) * Revert "Revert "add SimpleFSGetFolder for out-of-favs or non-canonical TLFs (#20452)" (#20485)" This reverts commit e657ab0. * review feedback from jakob * lint commit 76b681c Author: Joshua Blum <joshblum@keyba.se> Date: Tue Oct 22 11:56:58 2019 -0400 only badge failed CHAT type conversations (#20518) commit 64883d0 Author: Miles Steele <miles@milessteele.com> Date: Tue Oct 22 11:05:01 2019 -0400 remove upgrade-per-user-key option from config (#20465) commit dedb059 Author: heronhaye <surya@keyba.se> Date: Tue Oct 22 11:04:31 2019 -0400 tweak remember passphrase help copy (#20516) commit a501e1c Author: Adam Spooner <adamjspooner@gmail.com> Date: Tue Oct 22 10:14:06 2019 -0400 Update more styles for dark mode. (#20497) * Update sending animation for dark mode. * Update pending payment status colors for dark mode. * Add jump background back. * Fix sending animation dimensions on desktop. * Update message styles for highlighting in dark mode on mobile. * Correctly color exploding timer when highlighted. * Fix hover colors on higlighted messages in dark mode. * Prettier. * Update storyshots. * Fix TS error. commit 6158359 Author: Joshua Blum <joshblum@keyba.se> Date: Tue Oct 22 10:13:51 2019 -0400 improve @-mention matching with username normalization (#20508) commit 988ea79 Author: Adam Spooner <adamjspooner@gmail.com> Date: Tue Oct 22 09:53:49 2019 -0400 Update follow notification's badge. (#20506) * Remove padding on badge on follow notifications. * Update storyshots. * Prettier. commit ac2b610 Author: Mike Maxim <mike.maxim@gmail.com> Date: Tue Oct 22 09:40:47 2019 -0400 fix lint commit ffa2c15 Author: chrisnojima <cnojima@keyba.se> Date: Tue Oct 22 09:28:34 2019 -0400 Revert "more chat immer (#20476)" (#20515) This reverts commit 45792bd. commit 45792bd Author: chrisnojima <cnojima@keyba.se> Date: Mon Oct 21 21:53:55 2019 -0400 more chat immer (#20476) commit 5d634f4 Author: Maxwell Krohn <themax@gmail.com> Date: Mon Oct 21 20:44:03 2019 -0400 teams: fix for a broken team (#20511) * teams: fix for a broken team * fix comment commit 52b13f7 Author: Jakob Weisblat <jakob@keyba.se> Date: Mon Oct 21 18:25:00 2019 -0400 fix login spacing on mobile (#20512) commit ced9ed2 Author: Joshua Blum <joshblum@keyba.se> Date: Mon Oct 21 17:46:52 2019 -0400 remove unused getMsgOrdinal (#20510) commit c45d763 Author: Joshua Blum <joshblum@keyba.se> Date: Mon Oct 21 17:40:00 2019 -0400 Only badge text and attachment outbox errors (#20499) commit 0a32b85 Author: Danny Ayoub <danny.a95@gmail.com> Date: Mon Oct 21 17:03:04 2019 -0400 Teams key on ID - teamIDToName and primitive maps (#20498) * add teamIDToName map * wip * remove teamIDs in favor of reducing on teamIDToName * convert some maps * consolidate into teamDetails map commit 3a062cf Author: Adam Spooner <adamjspooner@gmail.com> Date: Mon Oct 21 16:09:14 2019 -0400 Fix underlined text on Android. (#20505) commit a04b7d1 Author: Adam Spooner <adamjspooner@gmail.com> Date: Mon Oct 21 15:49:15 2019 -0400 Update more styles and images for dark mode. (#20447) * WIP * WIP * Add dark mode placeholders. * Might be important. * Fix mention colors. * Add dark mode placeholders. * funfunfunction * Add dark more placeholders for avatar server. * Add white icon. * Set white icon. * Remove unused prop. * Update some Stellar styles. * Prettier. * Update storyshots. * Remove commented-out line. * Build actions. * 🔥 commit 4da2598 Author: Marco Munizaga <marco@marcopolo.io> Date: Mon Oct 21 11:27:33 2019 -0700 Enable V8 on Android (#20501) * try v8 on android * Use gradle property for v8 * Update V8 deps * Enable V8 commit 92d6957 Author: Joshua Blum <joshblum@keyba.se> Date: Mon Oct 21 13:37:22 2019 -0400 nuke nuking on too many open files error (#20495) commit 81b0ad5 Author: Patrick Crosby <pcrosby@gmail.com> Date: Mon Oct 21 11:26:06 2019 -0500 Pushing a commit to master for CI commit e5fcade Author: Joshua Blum <joshblum@keyba.se> Date: Mon Oct 21 12:00:28 2019 -0400 Fix nil error in ek storage (#20493) commit dd3840e Author: Danny Ayoub <danny.a95@gmail.com> Date: Mon Oct 21 12:00:15 2019 -0400 Allow devices named 'reset' in select-other-device (#20496) * Allow devices named 'reset' in select-other-device * Don't use the name field at all commit fbf3ad8 Author: Joshua Blum <joshblum@keyba.se> Date: Mon Oct 21 11:38:09 2019 -0400 Fix multiple word command matching for restricted bots (#20469) commit 1afa7d6 Author: chrisnojima <cnojima@keyba.se> Date: Mon Oct 21 10:49:42 2019 -0400 search rover (#20468) commit da0916f Author: Joshua Blum <joshblum@keyba.se> Date: Mon Oct 21 10:46:30 2019 -0400 don't badge invisible messages (#20491) commit 2f7275c Author: Joshua Blum <joshblum@keyba.se> Date: Mon Oct 21 09:49:07 2019 -0400 nix checkLogin (#20467) commit daa9282 Author: Song Gao <song@gao.io> Date: Sun Oct 20 15:33:41 2019 -0700 waitForMount->Go & fix bug where it checked wrong location on Catalina (#20422) * waitForMount->Go & fix bug where it checked wrong location on Catalina * check for preferred mounts as well; and other feedback from strib * there's nothing we can do about the timeout erorr so just ignore * review feedback strib commit e657ab0 Author: Song Gao <song@gao.io> Date: Sun Oct 20 15:31:39 2019 -0700 Revert "add SimpleFSGetFolder for out-of-favs or non-canonical TLFs (#20452)" (#20485) This reverts commit 6118736. commit 6118736 Author: Song Gao <song@gao.io> Date: Sun Oct 20 15:29:29 2019 -0700 add SimpleFSGetFolder for out-of-favs or non-canonical TLFs (#20452) commit e7ce8be Author: chrisnojima <cnojima@keyba.se> Date: Sat Oct 19 16:58:44 2019 -0400 animate send buttons on mobile (#20459) commit c33e507 Author: mmou <mmou@keyba.se> Date: Fri Oct 18 18:26:44 2019 -0400 modify login isOnline to use ConnectivityMonitor (#20472) commit 6595621 Author: Joshua Blum <joshblum@keyba.se> Date: Fri Oct 18 17:45:29 2019 -0400 Improve message retry strategies (#20240) * MarkConvAsError * 15m timeout instead of 2m * badge failed outbox items, LocalMtime * cleanup * lint * Append instead of Sprinkle * bug fixes * fix test * feedback commit 9a7852c Author: Chris Ball <chris@printf.net> Date: Fri Oct 18 14:27:41 2019 -0700 Better explanation text for invalid username on signup (#20454) * Better explanation text for invalid username on signup * underscores commit 5fad67d Author: Chris Ball <chris@printf.net> Date: Fri Oct 18 14:08:24 2019 -0700 Add a 'Please tell us' feedback button to desktop black bars (#20437) * Add a 'Please tell us' feedback button to desktop black bars * Feedback from Jacob Co-Authored-By: Jacob Young <jacob@jry.io> * comma commit 3c9ad02 Author: chrisnojima <cnojima@keyba.se> Date: Fri Oct 18 16:50:41 2019 -0400 faster hide (#20464) commit 3dada10 Author: Mike Maxim <mike@keyba.se> Date: Fri Oct 18 16:33:18 2019 -0400 dont clear team members map for non general (#20461) * dont clear team members map for non general * lint commit 163ad60 Author: cori hudson <54032873+hyperobject@users.noreply.github.com> Date: Fri Oct 18 16:24:17 2019 -0400 HOTPOT-1022: show extended description for multiword bot commands (#20462) * use regex that checks for marker separators * don't split bot command text, just check prefix * prefer longer command matches for extended display * remove unnecessary escape characters commit f988d54 Author: chrisnojima <cnojima@keyba.se> Date: Fri Oct 18 14:55:53 2019 -0400 android zoomable image (#20406) commit 73296cb Author: heronhaye <surya@keyba.se> Date: Fri Oct 18 14:29:05 2019 -0400 do not use secret store to check whether user is logged in in engine (#20309) * do not use secret store to check whether user is logged in in engine * fix some tests, add stayLoggedOut to config * set and access stayLoggedIn * set things less often * move config call to engine commit e7fda12 Author: Miles Steele <miles@milessteele.com> Date: Fri Oct 18 13:53:05 2019 -0400 upgrade avdl-compiler to 1.4.6 (#20445) commit d7b94df Author: chrisnojima <cnojima@keyba.se> Date: Fri Oct 18 11:24:36 2019 -0400 Animate chat sends on mobile (#20446) commit 6e54aa4 Author: Michał Zochniak <michal@zapu.net> Date: Fri Oct 18 16:48:29 2019 +0200 Redo invite by phone number / email screen on mobile (#20003) Redo invite by seitan screen on mobile (use hooks), remove `react-native-contacts` package - we use `expo-contacts` everywhere now. commit 32cef19 Author: Mike Maxim <mike@keyba.se> Date: Fri Oct 18 10:47:28 2019 -0400 dont hold lock when syncing (#20448) commit ecbf278 Author: chrisnojima <cnojima@keyba.se> Date: Fri Oct 18 10:11:11 2019 -0400 use animated.div (#20456) commit 300737d Author: Danny Ayoub <danny.a95@gmail.com> Date: Fri Oct 18 09:32:20 2019 -0400 Teams immer 1 - all fields except for the I.Map<Teamname, ...>s (#20444) * deletedTeams,teamsWithChosenChannels,teamAccessRequestsPending * teamProfileAddList * emailInviteError * teamnames,newTeams,newTeamRequests * no or commit bee9c06 Author: chrisnojima <cnojima@keyba.se> Date: Fri Oct 18 09:04:29 2019 -0400 fix lint (#20457) commit a6039de Author: Piotr Zduniak <piotr@zduniak.net> Date: Fri Oct 18 09:32:41 2019 +0100 avdl autoreset ui rework (#20439) commit f7355cf Author: chrisnojima <cnojima@keyba.se> Date: Thu Oct 17 22:03:45 2019 -0400 animate info panel and fix render thrashing (#20430) * animate info panel and fix render thrashing * handle start on attachments. use routepropt to init tab * animate out also * WIP commit b6e93ef Author: Antonio Marcedone <AMarcedone@users.noreply.github.com> Date: Thu Oct 17 18:09:17 2019 -0400 add exclusion proofs to merkletree2 (#20388) * use a single handle for each merkletree2 encoder * implement exclusion proofs * added rootHash input to StoreRootMetadata method * remove dead code * fix error message * bug fix * exported two position functions to make testing merklestorage easier * Added some comments commit 43afbc9 Author: Danny Ayoub <danny.a95@gmail.com> Date: Thu Oct 17 16:36:25 2019 -0400 Teams immer 0 - root state & reducer (#20433) * Root state and reducer * fixes * readonly the state commit 61cf3ba Author: Mike Maxim <mike@keyba.se> Date: Thu Oct 17 15:17:54 2019 -0400 fix send error display (#20443) commit 85026f2 Author: Piotr Zduniak <piotr@zduniak.net> Date: Thu Oct 17 20:13:39 2019 +0100 autoreset cleanup (#20441) commit cd39595 Author: Chris Ball <chris@printf.net> Date: Thu Oct 17 10:59:13 2019 -0700 Add "getdeviceinfo" chat API command (#20405) * Add "getdeviceinfo" chat API command * fix go type * Remove offlineavailability tolerance commit 8d9149b Author: Joshua Blum <joshblum@keyba.se> Date: Thu Oct 17 12:59:19 2019 -0400 add role to UpdateConversationMembership (#20427) * add role to UpdateConversationMembership * tlfid * nullable commit 3e4b9fd Author: cori hudson <54032873+hyperobject@users.noreply.github.com> Date: Thu Oct 17 12:56:13 2019 -0400 HOTPOT-1040: align chat titles with icons (#20428) * hide description box if not 1-on-1 and no desc * add extra padding if no desc * remove redundant check on p.desc commit 90e8061 Author: Patrick Crosby <patrick@keyba.se> Date: Thu Oct 17 11:50:11 2019 -0500 Add card checker, msg append in special channels (#20276) * Added new msg unboxed state * Chat api renders something for card type * Add all the card types * Remove debugging * Remove more debug * Rename Card -> JourneyCard * Rename type * Rebuild after rebase commit bdedd99 Author: Mike Maxim <mike@keyba.se> Date: Thu Oct 17 12:11:10 2019 -0400 better error message for failing min writer role (#20434) commit 433c258 Author: cori hudson <54032873+hyperobject@users.noreply.github.com> Date: Thu Oct 17 11:59:24 2019 -0400 fix logic for reply privately (#20429) * fix logic for reply privately option * snaps commit eae689c Author: Joshua Blum <joshblum@keyba.se> Date: Thu Oct 17 10:44:30 2019 -0400 annotate bot sender in cli (#20416) * botusername for restrictedbot messages * annotate bot sender in cli commit 2839da2 Author: Jakob Weisblat <jakob@keyba.se> Date: Thu Oct 17 10:16:32 2019 -0400 ff on (#20413) commit 3877427 Author: Danny Ayoub <danny.a95@gmail.com> Date: Thu Oct 17 09:58:29 2019 -0400 hide "check your inbox" banner on people tab when email is verified (#20409) * hide "check your inbox" banner on people tab when email is verified * clean log commit 15deb4a Author: Danny Ayoub <danny.a95@gmail.com> Date: Thu Oct 17 09:56:07 2019 -0400 Don't include currently selected conversation in inbox unreadIndices (#20414) commit 5519ee8 Author: Mike Maxim <mike@keyba.se> Date: Thu Oct 17 09:46:22 2019 -0400 nav to inbox on channel delete on mobile (#20412) commit f601c2a Author: chrisnojima <cnojima@keyba.se> Date: Thu Oct 17 09:24:14 2019 -0400 fix dark images (#20426) commit 446dbe9 Author: chrisnojima <cnojima@keyba.se> Date: Thu Oct 17 08:45:51 2019 -0400 more immer chat (#20319) commit d37d930 Author: Alex Gessner <alex.gessner@gmail.com> Date: Wed Oct 16 18:09:12 2019 -0400 team storage list/delete (#20352) * changes to api for team storage listing * team store delete * some updates to kv-revision-cache * pr feedback * more actionable/readable team-storage errors and more safety for the revision cache commit 64a190a Author: Jeremy Stribling <strib@alum.mit.edu> Date: Tue Oct 15 14:11:52 2019 -0700 libkb: don't panic if there's no user when getting mount dir This can apparently legitimately happen in the iOS simulator. Issue: HOTPOT-1041 commit 0fadd04 Author: Mike Maxim <mike@keyba.se> Date: Wed Oct 16 17:40:08 2019 -0400 apply sent styles to highlighted text messages (#20415) commit 117e23d Author: cori hudson <54032873+hyperobject@users.noreply.github.com> Date: Wed Oct 16 17:33:43 2019 -0400 add unfollow to overflow menu on tracker (#20410) commit 8aef40d Author: chrisnojima <cnojima@keyba.se> Date: Wed Oct 16 16:57:56 2019 -0400 fix dropshadow darkmode (#20411) commit e5e28cb Author: Joshua Blum <joshblum@keyba.se> Date: Wed Oct 16 16:54:10 2019 -0400 add ephemeral retry codes to team retry attempts (#20404) * add ephemeral retry codes to team retry attempts * lint * retry here too * no retry on login required commit 3a170dd Author: Mike Maxim <mike@keyba.se> Date: Wed Oct 16 15:46:09 2019 -0400 fix ui inbox loader shutdown (#20408) commit f3f88e9 Author: Danny Ayoub <danny.a95@gmail.com> Date: Wed Oct 16 15:34:50 2019 -0400 get rid of unneeded make functions in tracker2 constants (#20407) * fix maps in tracker2 constants * freeze! commit 52ff9ee Author: cori hudson <54032873+hyperobject@users.noreply.github.com> Date: Wed Oct 16 15:02:12 2019 -0400 incFocusInputCounter on service change (#20385) commit 5ac2d6c Author: Jeremy Stribling <strib@alum.mit.edu> Date: Tue Oct 15 15:40:49 2019 -0700 kbfs_ops: helper func for synced TLFs that filters out bad TLFs If the current user can't read a particular synced TLF, that's ok because they might not have access to it -- e.g., it could have been synced while logged in as a different user on this same device. That's ok, so just skip TLFs like that when listing favorites and the full sync config list. Do so using a helper function to look up the TLF node MDs and handles, while skipping inaccessible TLFs (after logging the error). Issue: Y2K-329 commit a218c4c Author: Jakob Weisblat <jakob@keyba.se> Date: Wed Oct 16 14:32:22 2019 -0400 ff (#20402) commit 27970bf Author: chrisnojima <cnojima@keyba.se> Date: Wed Oct 16 14:17:59 2019 -0400 fix error modes in chat (#20400) commit 7cfcbce Author: Mike Maxim <mike@keyba.se> Date: Wed Oct 16 12:50:14 2019 -0400 more desktop widget updates (#20401) commit cfec2b1 Author: Mike Maxim <mike.maxim@gmail.com> Date: Wed Oct 16 12:39:54 2019 -0400 fix tsc commit a5117c6 Author: Adam Spooner <adamjspooner@gmail.com> Date: Wed Oct 16 11:17:26 2019 -0400 Update dark mode styles. (#20384) * Update mention colors. * Fix inactive tab border color. * Improve contrast on code snippets. * Use white text on buttons. * Improve contrast on tab bar icons. * Use a blue spinner as the default. * Update ashes for dark mode. * Keep normal playing card colors in dark mode. * Fix yellow button. * Update icon color. * Add more dark icons. * Remove paper key corner icon. * Use getters. * Fix button icons. * Update storyshots. * Prettier. commit d1a75ea Author: Mike Maxim <mike@keyba.se> Date: Wed Oct 16 10:37:46 2019 -0400 fix desktop widget inbox situation (#20395) * break ground * wip * fix commit a992708 Author: chrisnojima <cnojima@keyba.se> Date: Wed Oct 16 10:28:56 2019 -0400 Start 4.8.0 cycle (#20394) * start 480 * start 480 commit 9c73088 Author: Danny Ayoub <danny.a95@gmail.com> Date: Wed Oct 16 10:27:27 2019 -0400 Add itemData to desktop inbox list (#20397) * Inline listChild in desktop inbox * use itemData instead commit c2daecc Author: chrisnojima <cnojima@keyba.se> Date: Wed Oct 16 10:25:44 2019 -0400 fix electron dark mode bug. fix add identities immer issue (#20396) commit 8662ea7 Author: Joshua Blum <joshblum@keyba.se> Date: Wed Oct 16 09:58:01 2019 -0400 headline snippet (#20386) commit e55e44e Author: Joshua Blum <joshblum@keyba.se> Date: Wed Oct 16 09:55:04 2019 -0400 consolidate system added to team messages (#20383) commit 75202db Author: chrisnojima <cnojima@keyba.se> Date: Wed Oct 16 09:52:45 2019 -0400 reduce inbox thrash (#20381) commit 2f525f3 Author: Antonio Marcedone <AMarcedone@users.noreply.github.com> Date: Tue Oct 15 17:29:01 2019 -0400 Introduced skip pointers in merkletree2 (#20218) * Introduced skip pointers in merkletree2, as well as MerkleExtensionProof and MerkleInclusionExtensionProof to check that those pointers. * minor * minor rename * Added RootVersion and AddOnsHash fields and removed EncodingType in RootMetadata. Added some inline comments to clarify how extension proofs are verified * readded encoding type * allow nil proof when initialSeqno=finalSeqno in extension proofs and clarified a test commit d2c50b0 Author: Mike Maxim <mike.maxim@gmail.com> Date: Tue Oct 15 16:05:41 2019 -0400 always refresh members just in case commit f9286c2 Author: Mike Maxim <mike@keyba.se> Date: Tue Oct 15 15:59:13 2019 -0400 load the team of selected conv even if we have the meta (#20378) commit d0a46a3 Author: Danny Ayoub <danny.a95@gmail.com> Date: Tue Oct 15 15:30:49 2019 -0400 Trim username in signup form (#20379) commit 49c723b Author: cori hudson <54032873+hyperobject@users.noreply.github.com> Date: Tue Oct 15 15:03:52 2019 -0400 Reloadable changes (#20373) * add feedback button to reloadable * filter reloadable errors by network errors * snaps * fix ci commit 999f723 Author: Jakob Weisblat <jakob@keyba.se> Date: Tue Oct 15 14:18:28 2019 -0400 reset: fix cancel button for end flow (#20325) * reset: fix cancel button for end flow * lint * ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.