Fix rust 1.87 windows linker error#687
Merged
michaelsutton merged 3 commits intokaspanet:masterfrom May 20, 2025
Merged
Conversation
coderofstuff
approved these changes
May 20, 2025
LiveLaughLove13
pushed a commit
to LiveLaughLove13/rusty-kaspa
that referenced
this pull request
Feb 10, 2026
* apply mimalloc fix to the new missing windows link * new line at eof * extend timeout for a test that freq fails on windows (timeout of a non-important part of the test)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle a new linker error on widows which is a result of the std lib no longer linking advapi32 by default
see https://releases.rs/docs/1.87.0/#compatibility-notes "Windows: The standard library no longer links advapi32" -> rust-lang/rust#138233
mimalloc was updated here to explicitly link advapi32: https://github.com/purpleprotocol/mimalloc_rust/blob/eff21096d5ee5337ec89e2b7174f1bbb11026c70/libmimalloc-sys/build.rs#L74
but not on latest release (0.1.46), so I had to ref a specific commit following release 0.1.46. I checked all commits since the release and nothing is risky (all changes are actually in build.rs), so ic no problem in referencing this commit.
Added a TODO to remove this workaround asap