Repository navigation
[Automated] Draft docs (kagent): fix(substrate): isolate worker pool placement by namespace - #590
Closed
github-actions[bot] wants to merge 1 commit into
Closed
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…placement by namespace Signed-off-by: GitHub Action <action@github.com>
Rachael-Graham
added a commit
that referenced
this pull request
Oct 13, 2026
Takes the content of three automated draft PRs into this branch rather than merging them. Each was cut before main rewrote the page it targets, so all three conflict with main on their own; the conflicts are not caused by the alpha12 work on this branch. #590, WorkerPool placement labels. Verified against the alpha12 chart: the substrate-workerpool template applies kagent.dev/worker-pool-name and kagent.dev/worker-pool-namespace through mergeOverwrite after substrateWorkerPool.labels, so an extra label reusing either key is overwritten. The chart's own unit test asserts kagent.dev/worker-pool is no longer set and records why a pinned revision from an earlier release still needs it. Compressed against the draft, which carried two field tables that restated their YAML. #589, push notification signing. controller.push.signing.secretName and .issuer both exist at v1.0.0-alpha12. Dropped the draft's numbered `helm upgrade` step: every other setting on this page shows the values block and leaves the upgrade implicit. Spelled out A2A, which the page used unexpanded. #582, Session share TTL. controller.sessionShareMaxTTL exists at alpha12. The draft added a row to a values table that main's rewrite replaced with prose, so the cap moved into the prose instead. Its cross-link pointed at #expire-idle-conversations, which no longer exists; retargeted to #expire-idle-sessions. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Rachael Graham <rachael.graham@solo.io>
Contributor
|
Absorbed into #591 (commit 0ef30c0), rewritten against the current page rather than merged — this branch was cut before main's rewrite of Content verified against the v1.0.0-alpha12 chart: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kagent-dev/kagent#3089 — fix(substrate): isolate worker pool placement by namespace
Docs versions:
1.x(first shipped in v1.0.0-alpha10)What changes for users: Generated ActorTemplates now select WorkerPools with both
kagent.dev/worker-pool-nameandkagent.dev/worker-pool-namespace, so same-named pools in different namespaces do not share Workers. Externally managed WorkerPools must carry both labels before upgrade, and old Sessions or Sandboxes need the oldkagent.dev/worker-poollabel until they are recreated.What the docs now say: The Tune Agent Substrate page now explains namespace-scoped WorkerPool placement, shows the labels for externally managed WorkerPools, and documents the temporary compatibility label for pre-upgrade revisions.
Not verified: The workflow captured the cluster API surface, but no configuration was applied and the steps are unrun.
How
kagent-3089was drafted, and what was not verifiedPlan, and what changed it
tune-agent-substrate.mdalready owns WorkerPool sizing, Helm values, Worker images, and sandbox-class changes;cluster-facts.mdconfirms WorkerPool isate.dev/v1alpha1.operations/tune-agent-substrate.md, plus an external WorkerPool example and compatibility guidance.Why a documentation change is necessary
The pull request changes Worker selection from the old name-only
kagent.dev/worker-poollabel to thekagent.dev/worker-pool-nameandkagent.dev/worker-pool-namespacelabels. The diff also says chart-managed pools get authoritative placement labels, while externally managed pools must carry both labels. The existing WorkerPool tuning page documented pool sizing, resources, sandbox class, and Worker images, but did not tell operators how placement labels work or what to do during upgrades.Rejected targets:
docs-site/content/kagent/1.x/about/architecture/agent-substrate.md: concept overview; useful background, but the user action is configuring WorkerPools.docs-site/content/kagent/1.x/about/substrate-runtime/_index.md: section index; no configuration belongs there.docs-site/content/kagent/1.x/about/substrate-runtime/identity.md: Agent Substrate authentication and identity, not Worker placement.docs-site/content/kagent/1.x/about/substrate-runtime/networking-and-egress.md: egress policy behavior, not WorkerPool selection.docs-site/content/kagent/1.x/about/substrate-runtime/sandboxing.md: sandbox class concepts, not WorkerPool metadata labels.docs-site/content/kagent/1.x/about/substrate-runtime/standalone-sandboxes.md: SandboxTemplate authoring, not chart-managed or external WorkerPool operations.docs-site/content/kagent/1.x/about/substrate-runtime/suspend-and-resume.md: lifecycle behavior, not placement configuration.docs-site/content/kagent/1.x/agents/agent-harness.md: Harness authoring;spec.substrate.workerPoolRef.namealready belongs to Harnesses, but the changed labels belong to WorkerPools.docs-site/content/kagent/1.x/operations/operational-considerations.md: production overview that already points readers to Tune Agent Substrate for pool sizing.docs-site/content/kagent/1.x/setup/installation.md: fresh install path; the chart sets the new labels automatically there.What changed on disk
docs-site/content/kagent/1.x/operations/tune-agent-substrate.md: Addedkagent.dev/worker-pool-name,kagent.dev/worker-pool-namespace, externally managed WorkerPool labels, and the temporarykagent.dev/worker-poolcompatibility label.How to verify this change
kubectl get workerpool kagent-default -n kagent \ -o jsonpath='{.metadata.labels.kagent\.dev/worker-pool-name}{" "}{.metadata.labels.kagent\.dev/worker-pool-namespace}{"\n"}'kagent-default kagent.kubectl get workerpool external-pool -n team-a \ -o jsonpath='{.metadata.labels.kagent\.dev/worker-pool-name}{" "}{.metadata.labels.kagent\.dev/worker-pool-namespace}{"\n"}'external-pool team-a. A new revision that references a pool without both labels staysReady=Falsewith reasonActorTemplatePending.What was not verified
The configuration was not applied to a cluster, so every command in this diff is unrun.
The upgrade transition for old Sessions and Sandboxes was not exercised in this sandbox.
How the pages were chosen (triage report)
Feature clusters
Kept apart on purpose. Merging wrongly produces a guide that documents two things and explains neither, so these are reported for a person to merge rather than grouped automatically:
docs-site/content/kagent/1.x/agents/agent-harness.mdas a candidate, but for one of them it is one page among more than 3, so they are kept apart; merge them if both drafts do land theredocs-site/content/kagent/1.x/agents/agent-harness.mdas a candidate, but for one of them it is one page among more than 3, so they are kept apart; merge them if both drafts do land theredocs-site/content/kagent/1.x/agents/agent-harness.mdas a candidate, but for one of them it is one page among more than 3, so they are kept apart; merge them if both drafts do land thereNew configuration: no page mentions it yet
kagent-dev/kagent#3089 — fix(substrate): isolate worker pool placement by namespace
kagent-dev/websitedocs/architecture/configuration-and-compilation.mdDraft branch:
pr-tracker-draft-kagent-3089Important
The test suite has not run on this pull request. It was opened by
github-actions[bot], and GitHub does not start workflows for pull requests opened with the repository's own token. This repository's checks are held asaction_requireduntil somebody presses Approve and run on the Checks tab. Checks that come from GitHub Apps rather than Actions, such as DCO, run on their own.Please approve the checks before reviewing the content: an absence of failures here means the tests have not run, not that they passed.