Repository navigation
fix: make session share tokens read-only - #3189
Merged
Merged
Conversation
timflannagan
previously approved these changes
Oct 13, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 13, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 13, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2026
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
EItanya
force-pushed
the
fix/read-only-session-shares
branch
from
October 14, 2026 11:02
2b30d83 to
835005c
Compare
timflannagan
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read/write share tokens allow visitors to send messages and cancel tasks as the session owner. This removes that capability for GA. All share tokens now grant read-only access, enforced in the services and transports, and shared conversations no longer expose reply, approval, cancellation, or retry controls.
Since shares have one access mode, this also removes the permission enum, protobuf fields, database column, and client/UI mappings. The unreleased initial schema and protobuf layout are updated directly, assuming a fresh installation.
Validated with protobuf generation and lint, focused Go and PostgreSQL race/migration tests, Go/UI lint and type checking, 67 UI unit tests, and 10 Chromium/Firefox sharing tests. Added cluster E2E coverage compiles; runtime execution requires
KAGENT_E2E_API_URL.