Repository navigation
feat(auth): tell UpstreamAuth which A2A call it is authorizing - #3178
Draft
codyhartsook wants to merge 1 commit into
Draft
codyhartsook wants to merge 1 commit into
codyhartsook wants to merge 1 commit into
Conversation
codyhartsook
marked this pull request as ready for review
October 13, 2026 14:42
codyhartsook
force-pushed
the
codyhartsook/upstreamAuthMethod
branch
from
October 13, 2026 18:20
3cc36fa to
72e0bb0
Compare
Signed-off-by: Cody Hartsook <cody.hartsook@solo.io>
codyhartsook
force-pushed
the
codyhartsook/upstreamAuthMethod
branch
from
October 13, 2026 18:43
72e0bb0 to
6bb2934
Compare
codyhartsook
requested review from
Charlesthebird and
EItanya
and removed request for
Charlesthebird
October 13, 2026 20:40
codyhartsook
marked this pull request as draft
October 14, 2026 14:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
UpstreamAuth now learns which A2A call it is authorizing, so an AuthProvider can treat a message send differently from a subscribe or a cancel. Providers read auth.UpstreamCallFrom(r.Context()), which returns UpstreamCallSend, UpstreamCallSubscribe, UpstreamCallCancel or UpstreamCallUnknown. The gateway derives the value from the a2a request type, so it does not depend on method name strings. The AuthProvider interface does not change.
Related Issues
None required.
Testing
go test -race ./core/pkg/auth/ ./core/internal/a2agateway/TestRuntimeDialerRoutesUnaryAndStreamingCalls checks the call UpstreamAuth sees for a send, a streaming send, a subscribe, a get and a cancel.
Change Type
/kind new_feature
Changelog