Skip to content

refactor: Remove obsolete skills-init code - #3144

Merged
EItanya merged 1 commit into
kagent-dev:mainfrom
timflannagan:cleanup/remove-skillsinit-cruft
Oct 11, 2026
Merged

EItanya merged 1 commit into
kagent-dev:mainfrom
timflannagan:cleanup/remove-skillsinit-cruft

Conversation

@timflannagan

Copy link
Copy Markdown
Contributor

Description

Remove the orchestration left behind when the skills-init binary and image were deleted in #2498. This includes the unused runner, configuration contract, Docker credential merging, SSH setup, mutable-ref clone path, and their tests.

The immutable Git commit, OCI, and S3 fetchers used by Agent Plugin materialization remain unchanged. Focused tests cover both the fetch package and its active consumer.

The skills-init binary and image were removed when runtime images were
simplified, but their orchestration code remained behind. Agent Plugin
materialization now uses only the immutable Git, OCI, and S3 fetch paths.

Remove the abandoned runner, configuration, authentication setup, and tests
while preserving the active artifact fetchers.

Signed-off-by: timflannagan <timflannagan@gmail.com>
@timflannagan
timflannagan requested a review from a team as a code owner October 9, 2026 22:17
@timflannagan

Copy link
Copy Markdown
Contributor Author

Noticed while trying to figure out why the dockerfile needed an alpine base, then saw we were execing out to git at runtime for some of the code, and then saw this, etc

@EItanya
EItanya added this pull request to the merge queue Oct 10, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Oct 10, 2026
@EItanya
EItanya added this pull request to the merge queue Oct 10, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Oct 10, 2026
@EItanya
EItanya added this pull request to the merge queue Oct 10, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Oct 10, 2026
@timflannagan
timflannagan added this pull request to the merge queue Oct 11, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Oct 11, 2026
@EItanya
EItanya added this pull request to the merge queue Oct 11, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 11, 2026
@EItanya
EItanya added this pull request to the merge queue Oct 11, 2026
Merged via the queue into kagent-dev:main with commit 755a6ba Oct 11, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants