Skip to content

fix(translator): accept Mistral ModelConfigs in v1alpha3 - #3008

Merged
EItanya merged 2 commits into
kagent-dev:mainfrom
moezdil:fix/mistral-v1alpha3
Oct 1, 2026
Merged

EItanya merged 2 commits into
kagent-dev:mainfrom
moezdil:fix/mistral-v1alpha3

Conversation

@moezdil

@moezdil moezdil commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

#2406 added mistral to the modelconfig enum and the adk renderer, but the v1alpha3 resolver still rejects it as an unsupported provider. so any agent that uses a mistral model fails to compile.

this pr lets the resolver accept mistral, sends MISTRAL_API_KEY as a bearer token to api.mistral.ai (or to the baseUrl if set), and allows that host in agent egress. each of the three parts has a new test that fails without this change.

The ModelConfig enum and the ADK renderer support Mistral, but the
resolver fell through to UnsupportedProvider, the API key had no gateway
credential target, and api.mistral.ai was never allowed in egress.

Signed-off-by: moezdil <mesudozdil@gmail.com>
@moezdil
moezdil requested a review from a team as a code owner September 29, 2026 21:31
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Sep 29, 2026
Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@EItanya
EItanya enabled auto-merge October 1, 2026 14:18
@EItanya
EItanya added this pull request to the merge queue Oct 1, 2026
Merged via the queue into kagent-dev:main with commit 542e0a7 Oct 1, 2026
30 checks passed
teemow added a commit to teemow/kagent that referenced this pull request Oct 2, 2026
* upstream/main: (79 commits)
  fix(translator): accept Mistral ModelConfigs in v1alpha3 (kagent-dev#3008)
  fix: allow disabling kagent model streaming (kagent-dev#3028)
  feat(helm): make the controller ServiceAccount optional (kagent-dev#3022)
  chore: bump retired gemini 2.5 default models to 3.5 (kagent-dev#3027)
  fix(api): defer unsupported configuration fields (kagent-dev#3007)
  docs: update README for the v1 architecture (kagent-dev#2996)
  fix: keep Go ADK SQLite connections out of VM snapshots (kagent-dev#3004)
  fix(ui): report harness delete failures (kagent-dev#2964)
  fix: repair image scans and use uv-managed Python (kagent-dev#2995)
  fix(e2e): wait for controller health and parallelize independent tests (kagent-dev#2993)
  fix(adk): pass MCP embedded resource text to OpenAI-compatible models (kagent-dev#2992)
  fix(controller): simplify agent preparation and retry handling (kagent-dev#2994)
  chore(deps): bump filelock from 3.29.4 to 4.0.3 in /python (kagent-dev#2982)
  chore(deps): bump the python-minor-patch group in /python with 6 updates (kagent-dev#2977)
  chore(deps): bump the python-google-ai group in /python with 2 updates (kagent-dev#2975)
  chore(deps): update wheel requirement from >=0.47.0 to >=0.48.0 in /python (kagent-dev#2981)
  chore(deps): update anthropic[vertex] requirement from >=0.120.0 to >=1.8.0 in /python (kagent-dev#2985)
  chore(deps): bump mcp from 1.29.0 to 2.2.0 in /python (kagent-dev#2984)
  fix(adk): keep Ollama tool call argument order stable across requests (kagent-dev#2988)
  chore(deps): update google-adk[a2a] requirement from <3,>=2.6.2 to >=2.9.2,<3 in /python (kagent-dev#2983)
  ...

Signed-off-by: Timo Derstappen <teemow@gmail.com>

# Conflicts:
#	go/adk/pkg/models/anthropic_adk.go
#	go/adk/pkg/models/anthropic_adk_test.go
#	go/core/internal/translator/adkconfig/model_test.go
#	python/packages/kagent-adk/src/kagent/adk/models/_anthropic.py
teemow added a commit to teemow/kagent that referenced this pull request Oct 2, 2026
* upstream/main: (79 commits)
  fix(translator): accept Mistral ModelConfigs in v1alpha3 (kagent-dev#3008)
  fix: allow disabling kagent model streaming (kagent-dev#3028)
  feat(helm): make the controller ServiceAccount optional (kagent-dev#3022)
  chore: bump retired gemini 2.5 default models to 3.5 (kagent-dev#3027)
  fix(api): defer unsupported configuration fields (kagent-dev#3007)
  docs: update README for the v1 architecture (kagent-dev#2996)
  fix: keep Go ADK SQLite connections out of VM snapshots (kagent-dev#3004)
  fix(ui): report harness delete failures (kagent-dev#2964)
  fix: repair image scans and use uv-managed Python (kagent-dev#2995)
  fix(e2e): wait for controller health and parallelize independent tests (kagent-dev#2993)
  fix(adk): pass MCP embedded resource text to OpenAI-compatible models (kagent-dev#2992)
  fix(controller): simplify agent preparation and retry handling (kagent-dev#2994)
  chore(deps): bump filelock from 3.29.4 to 4.0.3 in /python (kagent-dev#2982)
  chore(deps): bump the python-minor-patch group in /python with 6 updates (kagent-dev#2977)
  chore(deps): bump the python-google-ai group in /python with 2 updates (kagent-dev#2975)
  chore(deps): update wheel requirement from >=0.47.0 to >=0.48.0 in /python (kagent-dev#2981)
  chore(deps): update anthropic[vertex] requirement from >=0.120.0 to >=1.8.0 in /python (kagent-dev#2985)
  chore(deps): bump mcp from 1.29.0 to 2.2.0 in /python (kagent-dev#2984)
  fix(adk): keep Ollama tool call argument order stable across requests (kagent-dev#2988)
  chore(deps): update google-adk[a2a] requirement from <3,>=2.6.2 to >=2.9.2,<3 in /python (kagent-dev#2983)
  ...

Signed-off-by: Timo Derstappen <teemow@gmail.com>
alexdarbyshire pushed a commit to alexdarbyshire/kagent that referenced this pull request Oct 5, 2026
…3008)

kagent-dev#2406 added mistral to the modelconfig enum and the adk renderer, but
the v1alpha3 resolver still rejects it as an unsupported provider. so
any agent that uses a mistral model fails to compile.

this pr lets the resolver accept mistral, sends `MISTRAL_API_KEY` as a
bearer token to `api.mistral.ai` (or to the baseUrl if set), and allows
that host in agent egress. each of the three parts has a new test that
fails without this change.

Signed-off-by: moezdil <mesudozdil@gmail.com>
Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants