Repository navigation
fix: honor kagent Harness command and args - #2934
Merged
Merged
Conversation
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
EItanya
approved these changes
Sep 24, 2026
alexdarbyshire
pushed a commit
to alexdarbyshire/kagent
that referenced
this pull request
Oct 5, 2026
## Summary The Harness API exposes [`workload.command`](https://github.com/kagent-dev/kagent/blob/c61fad8bece10fb8e4c3ddcdb3a9c853a4154d90/go/api/v1alpha3/harness_types.go#L120) and [`workload.args`](https://github.com/kagent-dev/kagent/blob/c61fad8bece10fb8e4c3ddcdb3a9c853a4154d90/go/api/v1alpha3/harness_types.go#L125) as overrides but kagent compiler currently drops both fields. This affects both go and Python images. This PR passes those values through to the compiled Revision so the kagent Harness honors the existing API contract. (BYO already passes them through) The revision digest and Substrate container builder already handle these fields so no changes were needed there. Signed-off-by: Mark Rossetti <marosset@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Harness API exposes
workload.commandandworkload.argsas overrides but kagent compiler currently drops both fields.This affects both go and Python images.
This PR passes those values through to the compiled Revision so the kagent Harness honors the existing API contract.
(BYO already passes them through)
The revision digest and Substrate container builder already handle these fields so no changes were needed there.