Replace unsigned masks with toUnsigned method calls #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These masks are not descriptive and can easily get damaged when refactoring code or making minor changes. The JDK methods were added in Java 8 and perform the same operation, but with a descriptive method name. x & 0xFF => Byte.toUnsignedInt(x) x & 0xFFFFFFFF => Integer.toUnsignedLong(x)
Member
Author
|
Waiting on results of https://github.com/jruby/jruby/actions/runs/1993723361 to get more coverage. |
Member
Author
|
There's a failure or two in test:mri:core that also seems to be there without these changes (based on current jcodings master) so I think this change is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These masks are not descriptive and can easily get damaged when
refactoring code or making minor changes. The JDK methods were
added in Java 8 and perform the same operation, but with a
descriptive method name.
x & 0xFF => Byte.toUnsignedInt(x)
x & 0xFFFFFFFF => Integer.toUnsignedLong(x)