Add error handling to nginx export#4249
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for exporting “error” actions to Nginx configuration output, generating location blocks and return <code>; directives so error-based redirects can be represented in the Nginx export format.
Changes:
- Add Nginx export support for
action_type === 'error'by emittinglocationblocks withreturn <status>;. - Update conditional (agent/referrer) export paths to emit either
return(for errors) orrewrite(for URL actions) via a shared helper. - Add integration tests validating exact vs encoded locations and regex/case-insensitive location generation for error actions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/integration/import-export/test-nginx.php | Adds integration tests covering Nginx export output for error actions (exact, encoded, case-insensitive, regex). |
| includes/import-export/format/class-nginx.php | Implements error-action handling in the Nginx exporter, including location-line generation and conditional action output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add error support to nginx export output.