Unify notices#4242
Merged
Merged
Conversation
Make sure Redirection notices are always shown on Redirection pages, and other notices are not shown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes admin notice visibility on Redirection admin pages by ensuring Redirection-owned notices reliably display while other plugin notices are hidden, reducing UI interference from third-party admin notice behavior.
Changes:
- Adds a
redirection-noticeCSS class to Redirection-rendered notices (PHP + React) so they can be explicitly allowed. - Updates Redirection page SCSS to show only allowlisted notices (
redirection-notice/wpl-notice) and hide all other.notice/.update-nagelements on those pages.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/page/home/style.scss |
Adds allowlist/denylist rules to display Redirection-owned notices and hide other notices on Redirection pages. |
src/component/redirect-edit/warning.tsx |
Marks redirect-edit warning notices with redirection-notice so they remain visible under the new CSS rules. |
redirection-admin.php |
Marks PHP-rendered update nag / error notices with redirection-notice so they remain visible under the new CSS rules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure Redirection notices are always shown on Redirection pages, and other notices are not shown. This should help reduce other plugins hiding Redirection notices on it's own admin pages, while hiding other plugin notices on the same page.