Reuse existing JSON groups#4238
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the JSON import path to re-use existing redirect groups when an incoming JSON group references an ID that already exists in the database, instead of always creating a new group. This aligns JSON imports with real-world scenarios where exports/imports may be repeated into the same site.
Changes:
- Refactors JSON import group mapping to resolve group IDs via a new
get_group_id()helper that prefers existing groups. - Ensures missing group IDs referenced by redirects create a single fallback “Group” per distinct missing ID (via mapping reuse).
- Adds integration tests covering “reuse existing group ID” and “single fallback group per missing ID”.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/integration/fileio/test-json.php | Adds integration coverage for reusing existing groups and for fallback-group behavior when group IDs are missing. |
| includes/fileio/format/class-json.php | Refactors JSON import to resolve group IDs through get_group_id() and re-use existing groups when present. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When importing JSON, re-use any group if it already exists