Conversation
|
Regarding the failing build: that's SauceLabs failing to spin up outdated browsers again. I'll create an issue for that. The tests all pass, as you can see by scrolling upwards from this line. |
|
Hold on, I started fiddling with the Sauce labs tests and then found out that there are still some minor compatibility issues with |
|
Alright, fixed some more bugs and compatibility issues, kicked up some performance and finally got the Sauce tests to run smoothly most of the time. Really ready for review now. (Travis ran twice because this is both a PR and a branch on the main repo. The second build failed because Coveralls can't handle checking the same commit twice. I'll avoid this situation in the future by only issueing PRs from my fork.) |
The main reason for issuing a release now is the bugfix in #2876, but I'm bumping the minor version number rather than the patch number, because the new feature from #2877 already slipped into
masterbefore that. I'm not planning to draw special attention to the latter at this time, because the corresponding update to Contrib hasn't happened yet.@jashkenas I have already updated all the generated files. Only the following steps remain for you, once you've approved this PR (edit: the only interesting part of the diff is the index.html, which contains the new change log entry and a new section about engine compatibility):
TODOinline comment on lines 2656-2658 of theindex.htmlby the date of release.prepare-1.12.0intomaster.npm publish: this will re-generate the bundles and annotated sources again, but should leave your working tree in a clean state. You'll get that warning again about mixing named and default exports, possibly twice, which you can still ignore. It will disappear in version 2.0.masterintogh-pages.@sktguha This update will not include your planned optimization of
_.isEqualyet, but rest assured that your contribution is still welcome.@joshuacc FYI:
_.toPathwill be in this release.