Restore support for special filenames

[jaraco]

Closes python/cpython#123270

[jaraco]

That's interesting. The new backslash_is_not_separator test is failing on Windows:

____________________ TestPath.test_backslash_not_separator ____________________

self = <tests.test_path.TestPath testMethod=test_backslash_not_separator>

    def test_backslash_not_separator(self):
        """
        In a zip file, backslashes are not separators.
        """
        data = io.BytesIO()
        zf = zipfile.ZipFile(data, "w")
        zf.writestr("foo\\bar", b"content")
        zf.filename = ''
        root = zipfile.Path(zf)
        (first,) = root.iterdir()
>       assert not first.is_dir()
E       AssertionError

tests\test_path.py:634: AssertionError

It's not immediately obvious to me why.

[obfusk]

That's interesting. The new backslash_is_not_separator test is failing on Windows:

Oh yeah, ZipInfo.__init__() calls _sanitize_filename(), which will replace os.sep with /.

[jaraco]

Oh yeah, ZipInfo.__init__() calls _sanitize_filename(), which will replace os.sep with /.

I confirmed the same. I wonder if it's possible to construct a ZipFile with backslashes on Windows.

[jaraco]

Oh yeah, ZipInfo.__init__() calls _sanitize_filename(), which will replace os.sep with /.

I confirmed the same. I wonder if it's possible to construct a ZipFile with backslashes on Windows.

Looks like I can maybe overwrite the .filename after construction.

[jaraco]

@obfusk, any comments before I merge and cut a release?

[obfusk]

LGTM 👍