Add linting to CI #266
Merged
Add linting to CI #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanHealy33
previously approved these changes
Sep 7, 2018
SeanHealy33
reviewed
Sep 7, 2018
test/IntercomUsersTest.php
Outdated
| use GuzzleHttp\Middleware; | ||
|
|
||
| class IntercomUsersTest extends PHPUnit_Framework_TestCase | ||
| class IntercomUsersTest extends \PHPUnit_Framework_TestCase |
Contributor
There was a problem hiding this comment.
is the \ actually a php convention 😒
Contributor
Author
There was a problem hiding this comment.
Kind of, in a file with a namespace, if you don't specify the full path, it will look for the classes relative to the current namespace. That means without the slash it would be looking for Intercom\Test\PHPUnit_Framework_TestCase (which of course doesn't exist).
I have added a new commit that imports the external dependency so that we don't need that ugly backslash 😄
btw, PHPUnit 4 is very EOL, the new versions have a proper namespace (use PHPUnit\Framework\TestCase). We should consider upgrading it ⚒
SeanHealy33
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The PSR2 convention is followed in all the source files, so why not enforce PSR2 via CI 😃
How?
I added the PHP Code Sniffer validation to the CircleCI build. However, the tests were not compliant.
To make them compliant:
PHPUnit_Framework_TestCase,stdClassandDateTimeImmutable) need to either be imported with anusestatement or include a backward slash in front of them.