Skip to content

Standalone for cards::round5()#29

Open
KennethATaylor wants to merge 4 commits intoinsightsengineering:mainfrom
KennethATaylor:standalone-round5
Open

Standalone for cards::round5()#29
KennethATaylor wants to merge 4 commits intoinsightsengineering:mainfrom
KennethATaylor:standalone-round5

Conversation

@KennethATaylor
Copy link

What changes are proposed in this pull request?
(#28, @KennethATaylor) - Adding standalone for cards::round5() function, copied over tests, and updated lst_scripts data and documentation accordingly.

Closes #28


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • If a standalone script was updated, a comment is added to the script header (changelog) AND the last-updated field has been updated.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • If a standalone script was updated, a comment is added to the script header (changelog) AND the last-updated field has been updated.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".
  • Create an issue in any repositories using {standalone} to update the standalone scripts.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2026

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@KennethATaylor
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@ddsjoberg ddsjoberg self-requested a review February 26, 2026 23:29
Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Can you add a NEWS.md entry and we'll merge? Thanks for the contribution!

@KennethATaylor
Copy link
Author

Done! There was no NEWS.md file, so I created one with usethis::use_news_md(), but I removed the default "initial CRAN submission" bullet, since it seems like CRAN submission isn't the long-term goal? Flagging removal of that bullet just to make sure in case I am wrong.

Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add cards::round5() standalone

2 participants