Standalone for cards::round5()#29
Open
KennethATaylor wants to merge 4 commits intoinsightsengineering:mainfrom
Open
Standalone for cards::round5()#29KennethATaylor wants to merge 4 commits intoinsightsengineering:mainfrom
KennethATaylor wants to merge 4 commits intoinsightsengineering:mainfrom
Conversation
Contributor
|
✅ All contributors have signed the CLA |
Author
|
I have read the CLA Document and I hereby sign the CLA |
ddsjoberg
approved these changes
Feb 26, 2026
Collaborator
ddsjoberg
left a comment
There was a problem hiding this comment.
Looks great! Can you add a NEWS.md entry and we'll merge? Thanks for the contribution!
Author
|
Done! There was no NEWS.md file, so I created one with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
(#28, @KennethATaylor) - Adding standalone for
cards::round5()function, copied over tests, and updatedlst_scriptsdata and documentation accordingly.Closes #28
Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()last-updatedfield has been updated.devtools::test_coverage()Reviewer Checklist (if item does not apply, mark is as complete)
last-updatedfield has been updated.pkgdown::build_site(). Check the R console for errors, and review the rendered website.devtools::test_coverage()When the branch is ready to be merged: