Conversation
|
The spell check results are purely false-positives from what I can see |
|
CLA Assistant Lite bot ✅ All contributors have signed the CLA |
Code should be between ` and truetype should be one (does it have hypen?) the rest may be added to the spelling |
@cicdguy @shajoezhu how can we sign the CLA? |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
@gmbecker could you also fix the lintr warnings please? ^^ |
Signed-off-by: Davide Garolini <dgarolini@gmail.com>
Co-authored-by: Davide Garolini <dgarolini@gmail.com> Signed-off-by: Gabe Becker <gabembecker@gmail.com>
Co-authored-by: Davide Garolini <dgarolini@gmail.com> Signed-off-by: Gabe Becker <gabembecker@gmail.com>
Co-authored-by: Davide Garolini <dgarolini@gmail.com> Signed-off-by: Gabe Becker <gabembecker@gmail.com>
Co-authored-by: Davide Garolini <dgarolini@gmail.com> Signed-off-by: Gabe Becker <gabembecker@gmail.com>
Co-authored-by: Davide Garolini <dgarolini@gmail.com> Signed-off-by: Gabe Becker <gabembecker@gmail.com>
gmbecker
left a comment
There was a problem hiding this comment.
github decided some of my responses are part of "a review"...
Signed-off-by: Davide Garolini <dgarolini@gmail.com>
Co-authored-by: Davide Garolini <dgarolini@gmail.com> Signed-off-by: Gabe Becker <gabembecker@gmail.com>
|
can we close this one now? |
|
@Melkiades if you're satisfied the comments have all been addressed please feel free to close this |
Adds the concept of font-based width (number of spaces in the font setting) to wrapping and pagination logic. Lays foundation for upcoming PRs in rtables and rlistings repos.