Conversation
- Add test-flashbots Makefile target that runs ignored integration tests - Add flashbots-ci.yml workflow that runs on push to main and PRs - Uses nextest with --run-ignored=only to run flashbots integration tests Closes ENG-1300
dylanlott
left a comment
There was a problem hiding this comment.
This should be a triggerable job in Github Actions, but should not be added to the main CI pipeline. The Flashbots integrations tests are too flaky to be in the hot path. Also not sure if they still pass post-Fusaka.
Addresses review feedback - flashbots integration tests are too flaky for the main CI pipeline. Changed to workflow_dispatch so tests can be triggered manually when needed. Added optional 'ref' input to allow testing specific branches/commits.
|
Thanks for the review @dylanlott! Good call - I've updated the workflow to use Also added an optional Re: post-Fusaka compatibility - that's a good point. We can run the workflow manually once this is merged to verify current state. |
|
Hey @dylanlott — just following up on this. The workflow is now Given your note about post-Fusaka flakiness, I kept it simple — no schedule or automatic triggers. Manual-only gives full control over when to run these tests. Would you mind taking another look when you get a chance? 🙏 |
Summary
Adds
make test-flashbotscommand to the Builder CI pipeline.Changes
test-flashbotstarget that runscargo nextest run --run-ignored=only --workspaceto execute all ignored integration testsTesting
The workflow installs cargo-nextest and Foundry, then runs the integration tests that are currently marked with
#[ignore]annotations.Closes ENG-1300