Added the Leiden algorithm#399
Merged
gaborcsardi merged 2 commits intoigraph:devfrom Oct 23, 2020
vtraag:feature/leiden
Merged
Conversation
Member
Author
|
I just realised I forgot to update the documentation, it was just copy-pasted from Python interface. |
…ygen from required packages in Travis.
Member
Author
|
This PR closes #346 by the way. |
Member
|
Merged igraph/igraph#1422 now; I leave it up to someone familiar with the R internals to merge / close this one. |
|
Hi, just wondering if there is any rough timeline for this being merged? We're very interested in using this functionality in the Seurat R package once it's available. I'd be happy to help if there's anything I can do to move this along |
Member
Author
|
We should ask @gaborcsardi. As far as I am concerned this is good to go. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the Leiden algorithm to the R interface. I've also added a simple test.
The
functions.defdid not yet includeigraph_community_leidenin theigraphC core. For that reason thecigraphsubmodule points to this commit in thefix/leiden-Rbranch for now. If all is well here on the R side as well, we can mergefix/leiden-Rto themasterbranch, and update thecigraphsubmodule to themasterbranch.