Repository navigation
Return false when chained relations have different lengths - #95
Open
chetana1410 wants to merge 1 commit into
Open
chetana1410 wants to merge 1 commit into
chetana1410 wants to merge 1 commit into
Conversation
A strict zip raised ValueError for 1<x<3 against 1<x<3<5 when raise_on_error was set. Those answers are not equal. Fixes huggingface#93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #93.
verify(..., raise_on_error=True)raisedValueErrorwhen both answers were chained relations with a different number of terms.zip(..., strict=True)treated$1<x<3$against$1<x<3<5$as a comparison failure instead of a wrong answer.Different lengths now compare as not equal. A chain still matches the same chain.
raise_on_error=Falsewas already returning false for this case, because it swallowed the exception.