This repository was archived by the owner on Feb 3, 2023. It is now read-only.
holochain_metrics: use StatsByMetric(...) due to differing type params#2126
Merged
zippy merged 1 commit intoholochain:masterfrom Feb 24, 2020
Merged
holochain_metrics: use StatsByMetric(...) due to differing type params#2126zippy merged 1 commit intoholochain:masterfrom
StatsByMetric(...) due to differing type params#2126zippy merged 1 commit intoholochain:masterfrom
Conversation
Contributor
Author
|
CI seems happy :) |
zippy
approved these changes
Feb 24, 2020
Member
|
whoops, did a bad merge there. Should have been to develop. |
Contributor
Author
|
I assume you'll deal with merging this into develop then. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
stats.rs(theholochain_metricscrate) discovered in https://crater-reports.s3.amazonaws.com/pr-69340/try%239ff4d07208097950831ed4ea9d76feb1eafc8baa/reg/holochain_metrics-0.0.42-alpha5/log.txt. The problem here is that the type parameterDused in theSelftype is not the same as the one returned by the function. This was accepted due to a bug in the compiler and is being fixed by rust-lang/rust#69340.